[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [dtp-dev] Petition to include bug 286611 in DTP 1.7.1 RC3
|
-1 on this specific patch.
I scanned thru the patch and noticed some non backward-compatible API
changes.
For example,
org/eclipse/datatools/sqltools/result/model/IResultInstance.java
- public void moreResultSet(ResultSet resultset) throws SQLException;
+ public void moreResultSet(ResultSet resultset, String profileName)
throws SQLException;
org.eclipse.datatools.sqltools.result
- public ResultSetObject(ResultSet resultset, int maxRowCount, int
maxDisplayRowCount, boolean showLabels) throws SQLException
+ public ResultSetObject(ResultSet resultset, int maxRowCount, int
maxDisplayRowCount, boolean showLabels, String profileName) throws
SQLException
In addition, the org.eclipse.datatools.sqltools.result plugin is adding
a dependency on org.eclipse.debug.core, which is discouraged.
We have a long standing bug to remove such dependency so that sqltools
can be used in a RCP application. (See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=275522 )
Linda
-----Original Message-----
From: dtp-dev-bounces@xxxxxxxxxxx [mailto:dtp-dev-bounces@xxxxxxxxxxx]
On Behalf Of Brian Fitzpatrick
Sent: Tuesday, September 01, 2009 1:32 PM
To: DTP development mailing list
Cc: Hui.Cao@xxxxxxxxxx
Subject: Re: [dtp-dev] Petition to include bug 286611 in DTP 1.7.1 RC3
So long as this is bounded bug fixing, I'm good with these fixes.
+1
--Fitz
_______________________________
Brian Fitzpatrick (aka "Fitz")
Senior Software Engineer, SOA-P
JBoss by Red Hat
----- Original Message -----
From: "Hui Cao" <Hui.Cao@xxxxxxxxxx>
To: dtp-pmc@xxxxxxxxxxx
Cc: dtp-dev@xxxxxxxxxxx
Sent: Tuesday, September 1, 2009 3:05:49 AM GMT -07:00 US/Canada
Mountain
Subject: [dtp-dev] Petition to include bug 286611 in DTP 1.7.1 RC3
Hi PMC,
I'd like to ask for PMC's approval to check in the fix for 286611. The
patch for this bug fixed the following problems:
1. Supported customize the display format of specific data type. This
one is to fix 243775 "Oracle timestamp not displayed".
2. Fixed a regression about breakpoint produced in the UI/NON-UI
refecatoring.
3. Fixed a SchemaObjectEditor defect of missing cheatshet link and mutex
of multiple thread refresh.
4. Fixed routine code fetching error in
"org.eclipse.datatools.sqltools.core.internal.dbitem".
5. Fixed ClassCastException when change the value of Max row count and
Max display row count for 287059.
6. Fixed a result display bug caused by swithcing active result items
when executing a long sql statement.
7. Fixed elapsed time defect when run procedure or function indirectly.
8. When handle a schema object editor after refresh, there was a NPE.
So actually this is a bundled bug fixing. The risk is low to medium, and
it has been reviewed by our internal engineers. Thanks.
Best Regards!
Max (Hui) Cao
Sybase Shanghai RD
----- Forwarded by Hui Cao/SYBASE on 09/01/2009 04:52 PM -----
bugzilla-daemon@xxxxxxxxxxx
09/01/2009 04:42 PM
To hui.cao@xxxxxxxxxx
cc
Subject [Bug 286611] SQL tools need upadate
https://bugs.eclipse.org/bugs/show_bug.cgi?id=286611
Product/Component: Data Tools / SQLDevTools
--- Comment #5 from Joe Wu <juewu@xxxxxxxxxx> 2009-09-01 04:36:45 EDT
---
Created an attachment (id=146165)
delta patch
When handle a schema object editor after refresh, there was a NPE.
Reproducing Step:
1. Connect to a CP.
2. Open a Table, Stored Procedure or other schema object with Schema
Object
Editor.
3. Refresh it.
4. Do any operation with the opened schema object editor.
after step4, there was an NullPointerException.
I fixed it in this delta patch.
--
Configure bugmail: https://bugs.eclipse.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev
_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev
