| RE: [dsdp-tml-dev] a more generic qemu service plugin |
|
From: Otavio Luiz
Ferranti [mailto:otavio.ferranti@xxxxxxxxxxxxxxx] Hi Yufen, My comments and 3 questions are highlighted in RED... Fabio, Daniel, please, provide your
opinions. (Please, always CC the dsdp-tml-dev@xxxxxxxxxxx list.) Regards, Otávio > -----Original
Message----- > From:
Yu-Fen Kuo [mailto:ykuo@xxxxxxxxxx] > Sent:
segunda-feira, 2 de junho de 2008 17:51 > To:
Otavio Luiz Ferranti > Subject:
RE: [dsdp-tml-dev] a more generic qemu service plugin > > > Hi Otavio, > > I am interested to work on the generic qemu plugin, and I am
just > wondering > are you ok with what I proposed below? For example: adding a new
extension > point for device type? [Otávio] 1 - It may be a good idea ... could you
give more details?
(More illustrative examples)
Note: I
submitted a patch yesterday that adds a default properties editor. The BUG is the 221733. [Yufen] I am thinking instead of using the org.eclipse.tml.device
extension point, create one that is called org.eclipse.tml.deviceTypes <extension
point="org.eclipse.tml.deviceTypes"> <deviceType
id="org.eclipse.tml.device.qemu.generic"
label="QEMU"
name="Generic QEMU device">
<property
name="icon" value="icons/full/obj16/qemuarm.gif">
</property>
</deviceType>
</extension> And all the services will be mapped to
the device type unlike in the current model, you need to redefine the same set
of services if there are new device created. For different device types, you
can have different set of services defined. > If there is no objection
from you, I would like to start working on it. > > Thanks > Yufen > > -----Original
Message----- > From:
dsdp-tml-dev-bounces@xxxxxxxxxxx > [mailto:dsdp-tml-dev-bounces@xxxxxxxxxxx]
On Behalf Of Otávio Luiz > Ferranti > Sent: Friday, May
30, 2008 8:19 AM > To: 'Tools for
Mobile Linux' > Cc: 'Eugene
Melekhov'; 'Joe Green' > Subject: RE:
[dsdp-tml-dev] a more generic qemu service plugin > > > Yufen > > I added my
comments below ... > > Regards > Otávio > > > -----Original Message----- > > From: dsdp-tml-dev-bounces@xxxxxxxxxxx [mailto:dsdp-tml-dev- > > bounces@xxxxxxxxxxx] On Behalf Of Yu-Fen Kuo > > Sent: quinta-feira, 29 de maio de 2008 20:21 > > To: dsdp-tml-dev@xxxxxxxxxxx > > Cc: 'Eugene Melekhov'; 'Joe Green' > > Subject: [dsdp-tml-dev] a more generic qemu service plugin > > > > Hi All, > > > > I am wondering if you
guys have any thoughts of implementing a more > > generic > > qemu plugin instead of
having to create one plugin for each different > > kind
of
qemu guest os. > > > [Otávio] I guess
it is not in our plans, those plugins are samples ... > however if this
new generic plugin would be used by many-many-many people > we could develop
that ... > > Obviously, it
would be great to receive a contribution from the community > to enhance those
QEMU plugins :) > > > > We should modify the extension for the device so we have a
generic qemu > > device type that has the predefined set of services
available. And user > > could configure the settings in the UI instead of hard
coding it in the [Otávio] 2 - Could you give more details about
this use case?
3 - From which view the user would
access the properties edition? [Yufen] In the new instance creation wizard, user can specify
the device type of this instance in the first page of the wizard. (Available
device types will come from the “org.eclipse.tml.deviceTypes”
extension) And in the subsequent pages of the wizard, user can specify the settings
of this device type. For example: if the device type is “QEMU”, in the
subsequent pages of the wizard, user should be able to specify settings like QEMU
start script path, parameters to start QEMU, kernel image name, if they want to
enable vnc or not… By doing this, the QEMU distribution does not need to be
copied into the plugin, nor needs it to be in the workspace. Once the instance is created, user can right click on the instance
to bring up the context menu or in the instance view toolbar to edit the settings. > > Plugin class itself. So if you need to add a new device for
different > > architecture, you can just add one from the UI instead of
modify the > > plugins. > > > > And also since the qemu settings are configurable, there is
no need to > > have > > all the qemu binaries in the plugin itself. > > > > So here is what I am proposing: > > > > 1. Create the extension point for developers to create the
device type. > > a. Define the device type and its
required info (QEMU could be one of > > the device
type) > > b. Point to class(handler) on what kind
of UI is required when user > > want to
add a new device of this type. > > c. Define the services that this device
type can handle (could be > > defined with
the org.eclipse.tml.serviceDefinition extension) > > > > 2. Create the device manager view > > a. For user to add/delete the device
instance for the specified > > device type > > b. modify settings of the device, default
ip address/port number > > information. > > > [Otávio] I´m
working on 2.a and 2.b ... it will be submitted in few days. > > - Instance
creation shall be still performed through the > "File->New->Project->Emulators->QEMU
React Device Instance Wizard" (in > QEMU React device
plugin case). > > Each device
plugin shall have its own "New Instance Wizard"... even if > it´s just
extending without (overriding) the > AbstractNewEmulatorInstanceWizard
and AbstractWizardCustomizer classes. > > - You will be
able to delete the instances from the "Other/Instance View" > using a context
menu. > > > > c. for user to create the launch
configuration settings for qemu > > paramaters. For example: qemu executable location, working
directory, > > kernel > > image file name, vnc settings. The qemu installed location
shouldn't > > need
to
be
part of the workspace. > > d. add actions/menus for user to run the
services(start, stop, > > connect
to
vnc,
disconnect to vnc, etc...)available on this device > > type. > > > > 3. The Launch configuration tabs UI should also be defined,
currently, > > if
I
go
into the launch configuration dialog, I get errors. > > > > We could also integrate it more with the DSDP/TM plugins
where when a > > qemu
device
is started; we could automatically create a new remote > > connection in
RSE's
remote systems explorer for the qemu target. > > > > > > Yufen > > > > > > _______________________________________________ > > dsdp-tml-dev mailing list > > dsdp-tml-dev@xxxxxxxxxxx > > https://dev.eclipse.org/mailman/listinfo/dsdp-tml-dev > > > _______________________________________________ > dsdp-tml-dev mailing list > dsdp-tml-dev@xxxxxxxxxxx |