[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [dsdp-tm-dev] Approval for bug 172483([terminal]Secondaryterminals cannot be shown in other perspectives)
|
Thanks Michael.
With respect to testing, we'll have plenty of time for 3.0.1
so I'm not worried about that one at all. It's more a
general question of whether we allow changes that (slightly)
modify the UI in the maintenance stream, or not.
As I've said, I'm personally much in favor of it, especially
given the fact that the UI changes can be kept minimal. But
I wanted to ask other committer's opinions.
As one additional piece of information, we'll continue
working on the 3.0.1 maintenance stream in HEAD until
mid-august presumably, so we don't need to fear any
merge issues if we apply the patch soon (whereas
postponing the patch might cause merge issues later).
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: dsdp-tm-dev-bounces@xxxxxxxxxxx
> [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of Scharf, Michael
> Sent: Wednesday, June 25, 2008 4:13 AM
> To: Target Management developer discussions
> Subject: RE: [dsdp-tm-dev] Approval for bug
> 172483([terminal]Secondaryterminals cannot be shown in other
> perspectives)
>
> +1
>
> we need a bit of testing but I am quite confident that
> the changes work. I did a long review session with Uwe
> and we looked at all the changes. It seems safe, but
> I want some more feedback on the UI. Like the clone
> button might not make too much sense and should the
> terminal be pinned by default.
>
> Here is a screencast showing the feature:
> http://scharf.gr/eclipse/terminal/MultipleSessions/
>
> Here is a trial version:
>
> http://scharf.gr/eclipse/terminal/MultipleSessions/terminal_bu
> g_172483.z
> ip
>
> Comments here:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=172483
>
>
> Michael
>
> --
> Michael Scharf, Wind River
> direct +49.6621.586.0139 mobile +49.173.664.2579 fax +49.6221.436.805
>
> > -----Original Message-----
> > From: dsdp-tm-dev-bounces@xxxxxxxxxxx
> > [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of
> > Oberhuber, Martin
> > Sent: Tuesday, 24 June, 2008 19:34
> > To: Target Management developer discussions
> > Subject: RE: [dsdp-tm-dev] Approval for bug 172483
> > ([terminal]Secondaryterminals cannot be shown in other perspectives)
> >
> > TM Committers,
> >
> > this message didn't get answered by anyone except Rado.
> > Please see my comment
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=172483#c18
> >
> > I'd love to see the contribution in TM 3.0.1. All the terminal
> > stuff is "internal" so it's nominally not an API change; it does,
> > however, add an icon (so screenshots of the Terminal View would
> > look slightly different between TM 3.0.1 and TM 3.0), and
> it does add
> > some PII.
> >
> > What do other committers think about adding such a feature
> to TM 3.0.1
> > ??
> >
> > Cheers,
> > --
> > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > Target Management Project Lead, DSDP PMC Member
> > http://www.eclipse.org/dsdp/tm
> >
> >
> >
> > > -----Original Message-----
> > > From: dsdp-tm-dev-bounces@xxxxxxxxxxx
> > > [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of
> > Scharf, Michael
> > > Sent: Thursday, June 12, 2008 5:05 AM
> > > To: Target Management developer discussions
> > > Subject: [dsdp-tm-dev] Approval for bug 172483 ([terminal]
> > > Secondaryterminals cannot be shown in other perspectives)
> > >
> > > Hi,
> > >
> > > Before Martin left for his vacation, I have been working on the
> > > terminal bug 172483:
> > > Secondary terminals cannot be shown in other perspectives
> > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=172483
> > >
> > > Martin was not able to review the final version of the change and
> > > now I am looking for reviewers on this list.
> > >
> > > I also created a little flash demo showing the feature:
> > >
> > > http://scharf.gr/eclipse/terminal/MultipleSessions/
> > >
> > > I tried to make it minimal changes and the only real changes
> > > I made was in the class
> > > org.eclipse.tm.internal.terminal.view.TerminalView.
> > > Although I started with minimal changes, I had to do some
> rework of
> > > this class to get the bug fixed. I also had to extract quite some
> > > code into new classes....
> > >
> > > For the review we could aso have a netmeeting session and go
> > > over the code..
> > >
> > > I did quite some testing (on windows and linux) and I am pretty
> > > confident that everything works. But it would be great if someone
> > > could try it out.
> > >
> > > If you want to test the new feature I have put the modified
> > plugins to
> > >
> > > http://scharf.gr/eclipse/terminal/MultipleSessions/terminal_bu
> > > g_172483.z
> > > ip
> > >
> > > Michael
> > >
> > > --
> > > Michael Scharf, Wind River
> > > direct +49.6621.586.0139 mobile +49.173.664.2579 fax
> > +49.6221.436.805
> > > _______________________________________________
> > > dsdp-tm-dev mailing list
> > > dsdp-tm-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> > >
> > _______________________________________________
> > dsdp-tm-dev mailing list
> > dsdp-tm-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> >
> _______________________________________________
> dsdp-tm-dev mailing list
> dsdp-tm-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
>
