Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tm-dev] RE: StructuredViewer.handleLabelProviderChanged(LabelProviderChangedEvent event)

Hi Dave,
 
my colleague Markus Schorn, CDT committer and Eclipse wizard, said
that he knew about the performance issues related to that method, but
had not heard about the workaround you suggest (overriding the method
to do nothing).
 
He thinks that in some situations (depending on viewer type), that might
make sense.
 
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
 
 


From: David McKnight [mailto:dmcknigh@xxxxxxxxxx]
Sent: Thursday, May 29, 2008 5:36 PM
To: Oberhuber, Martin
Subject: RE: StructuredViewer.handleLabelProviderChanged(LabelProviderChangedEvent event)


Here's the sort of stack I see with this:


        ContentViewer$1.labelProviderChanged(LabelProviderChangedEvent) line: 74        
        DecoratorManager$1.run() line: 430        
        SafeRunner.run(ISafeRunnable) line: 37        
        DecoratorManager.fireListener(LabelProviderChangedEvent, ILabelProviderListener) line: 428        
        DecorationScheduler$3.runInUIThread(IProgressMonitor) line: 533        
        UIJob$1.run() line: 94        
        RunnableLock.run() line: 35        
        UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 130        
        Display.runAsyncMessages(boolean) line: 3750        
        Display.readAndDispatch() line: 3375        
        Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 2375        
        Workbench.runUI() line: 2339        
        Workbench.access$4(Workbench) line: 2205        
        Workbench$4.run() line: 478        
        Realm.runWithDefault(Realm, Runnable) line: 288        
        Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 473        
        PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 149        
        IDEApplication.start(IApplicationContext) line: 106        
        EclipseAppHandle.run(Object) line: 193        
        EclipseAppLauncher.runApplication(Object) line: 110        
        EclipseAppLauncher.start(Object) line: 79        
        EclipseStarter.run(Object) line: 362        
        EclipseStarter.run(String[], Runnable) line: 175        
        NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]        
        NativeMethodAccessorImpl.invoke(Object, Object[]) line: 45        
        DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 25        
        Method.invoke(Object, Object...) line: 612        
        Main.invokeFramework(String[], URL[]) line: 549        
        Main.basicRun(String[]) line: 504        
        Main.run(String[]) line: 1236        
        Main.main(String[]) line: 1212        

____________________________________
David McKnight    
Phone:   905-413-3902 , T/L:  969-3902
Internet: dmcknigh@xxxxxxxxxx
Mail:       D1/YFY/8200/TOR
____________________________________



"Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>

29/05/2008 11:33 AM

To
David McKnight/Toronto/IBM@IBMCA
cc
Subject
RE: StructuredViewer.handleLabelProviderChanged(LabelProviderChangedEvent event)





I haven't. I'm going to ask Uwe, he's been working in that area.
 
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
 
 


From: David McKnight [mailto:dmcknigh@xxxxxxxxxx]
Sent:
Thursday, May 29, 2008 5:24 PM
To:
Oberhuber, Martin
Subject:
StructuredViewer.handleLabelProviderChanged(LabelProviderChangedEvent event)



Hi Martin,


I'm seeing a problem with eclipse calling this fairly regularly when we have a lot of items in our trees and tables (i.e. over 10,000 items).  I've found that we can resolve performance issues by overriding this method to do nothing.  What I'm wondering is if this is an issue you've heard about.  Do you know of any issues with this one?


Thanks,


____________________________________
David McKnight    
Phone:   905-413-3902 , T/L:  969-3902
Internet: dmcknigh@xxxxxxxxxx
Mail:       D1/YFY/8200/TOR
____________________________________


Back to the top