[dsdp-tm-dev] RSE Folder selection (was: fix for bug 220995)

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hello Yu-Fen,

We really want to standardize on ONE API for file/folder
Selection. I know that Xuan and Kevin have been thinking
About this a little.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=220995

Can you please file a bug for your request, search bugzilla
For existing bugs in this area, and link them to your new
Bug.

Xuan, Kevin and other committers what do you think?

Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
 
 

> -----Original Message-----
> From: Yu-Fen Kuo [mailto:ykuo@xxxxxxxxxx] 
> Sent: Donnerstag, 08. Mai 2008 23:31
> To: xuanchen@xxxxxxxxxx; Oberhuber, Martin
> Cc: 'Anna'
> Subject: bug fix for 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=220995
> 
> Hi Xuan and Martin,
> 
> I am trying out our code with latest Ganymede RSE code, and 
> I've found that
> the setAllowFolderSelection api from 
> SystemSelectRemoteFileAction class is
> removed in Ganymede. 
> 
> In SystemSelectRemoteFileAction, user was able to select 
> either a file or
> folder, and if setAllowFolderSelection was set to false, the 
> ok button will
> be disabled when user selects a folder. (This is how it was 
> behaving in
> Europa)
> 
> There is also another class SystemSelectRemoteFolderAction 
> where user is
> only allow to select a folder.
> 
> But in Ganymede, this api is removed, and there is no easy 
> way to restrict
> the selection to file only. This is a regression in 
> functionality. Now the
> only workaround I have is to set the selectionValidator. And 
> to implement
> IValidatorRemoteSelection interface, you need to return the 
> SystemMessage
> which is a bit kludgy for ISVs.
> 
> I believe since RSE offers 2 different classes for different remote
> file/folder selection action, it should make the API easier 
> for user to
> specify the file type selection.  Now moving to Ganymede, it 
> seems to make
> it more confusing. 
> 
> The addition of customViewFilter in 
> SystemSelectRemoteFileAction is also
> confusing; since there are both viewFilters and 
> customerViewerFilter as
> member fields and now viewerFilter is not being used at all 
> anymore. And the
> addViewerFilter api is not marked as depreciated yet.
> 
> I hope you can revisit the changes you made in 
> SystemSelectRemoteFileAction,
> and make the migration less kludgy for Ganymede.
> 
> Thanks
> Yufen
> 
>