[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [dsdp-tm-dev] RSE 3.0M7 Testing
|
Great catch, Rado.
I fixed it:
[199854] Regression in FTPService deletes files after upload
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: dsdp-tm-dev-bounces@xxxxxxxxxxx
> [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of
> Radoslav Gerganov
> Sent: Mittwoch, 07. Mai 2008 15:56
> To: Target Management developer discussions
> Subject: Re: [dsdp-tm-dev] RSE 3.0M7 Testing
>
> I was right -- this bug is introduced from the IFileService
> refactoring.
>
> FTPService#internalUpload() was changed from:
> ...
> if(retValue==false) {
> ftpClient.deleteFile(remoteFile);
> }
> ...
>
> to
>
> ...
> ftpClient.deleteFile(remoteFile);
> ...
>
> in revision 1.64 by ddykstal. Dave, could you please revise
> this change?
>
> Cheers,
> Rado
>
> Radoslav Gerganov wrote:
> > All,
> >
> > I found a major bug using the M7 candidate on "FTP Only"
> connection. When I open a remote ftp file,
> > make some changes and save it, the file is deleted from the
> filesystem. Here is part of the log from
> > my ftp server:
> >
> > ...
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> 226 Transfer OK
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> NOOP
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> 200 OK
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> CWD /
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> 250 CWD
> successful. "/" is current directory.
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> PORT
> 127,0,0,1,14,107
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> 200 Port
> command successful
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> STOR strace.txt
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> 150
> Opening data channel for file transfer.
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> 226 Transfer OK
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> DELE strace.txt
> > (000006) 07.5.2008 . 16:16:07 - rado (127.0.0.1)> 250 File
> deleted successfully
> > ...
> >
> > All I do is inserting some characters in the file and
> saving it. However, RSE send a delete command.
> > This is a regression since it doesn't happen with M6 using
> the same ftp server and the same ftp account.
> >
> > I am using Eclipse 3.4M6 on a Windows machine, my ftp
> server is FileZilla running on the localhost.
> > I suppose this bug could be a regression from the
> IFileService refactoring.
> >
> > Rado
> >
> > Oberhuber, Martin wrote:
> >> Hi All,
> >>
> >> I know that we're a day late, but after this week's
> "monster" Refactoring
> >> of the IFileService APIs, it's still taking a bit of time
> to getting
> >> everything
> >> stable again.
> >>
> >> An M7 candidate is now available on
> >> http://download.eclipse.org/dsdp/tm/downloads/drops/I20080507-0540/
> >> Please get it and give it some testing!
> >>
> >> I've done a basic sanity check (Combined Unit Test Suite)
> on Windows
> >> and Linux, and both are fine. Currently, I'm runnign the
> DStore Archive
> >> Test Suite, which still produces test failures on most tests; so,
> >> remote archive handling on dstore is currently likely to fail.
> >>
> >> For everything else, you should be good to go. Let's give approx
> >> 2 hours of testing before a final Fix phase and M7 release.
> >>
> >> Thanks for your help!
> >>
> >> Cheers,
> >> --
> >> *Martin Oberhuber*, Senior Member of Technical Staff, *Wind River*
> >> Target Management Project Lead, DSDP PMC Member
> >> http://www.eclipse.org/dsdp/tm
> >>
> >>
> >>
> >>
> >>
> --------------------------------------------------------------
> ----------
> >>
> >> _______________________________________________
> >> dsdp-tm-dev mailing list
> >> dsdp-tm-dev@xxxxxxxxxxx
> >> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> > _______________________________________________
> > dsdp-tm-dev mailing list
> > dsdp-tm-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> >
> >
> _______________________________________________
> dsdp-tm-dev mailing list
> dsdp-tm-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
>
