[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tm-dev] RE: ServerLauncher v1.15

Ah, I was confused because there are two instances of ServerLauncher.
I thought about

org.eclipse.rse.internal.core.subsystems.ServerLauncher

which is part of the Client and should not have System.exit().
The dstore variant of ServerLauncher can have it.

Thanks for the clarification.

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm

 


From: David McKnight [mailto:dmcknigh@xxxxxxxxxx]
Sent: Thursday, December 06, 2007 3:45 PM
To: Oberhuber, Martin
Cc: Target Management developer discussions
Subject: Re: ServerLauncher v1.15


ServerLauncher is a class that runs on the remote machine, not in Eclipse.  This exit happens if we can't create a socket for the dstore daemon to listen to - in that case, we have to shut down the daemon.

____________________________________
David McKnight    
Phone:   905-413-3902 , T/L:  969-3902
Internet: dmcknigh@xxxxxxxxxx
Mail:       D1/YFY/8200/TOR
____________________________________



"Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>

06/12/2007 05:09 AM

To
David McKnight/Toronto/IBM@IBMCA
cc
"Target Management developer discussions" <dsdp-tm-dev@xxxxxxxxxxx>
Subject
ServerLauncher v1.15





Hi Dave,

in ServerLauncher v1.15 you made this change:

dstore - need to exit with a message if port already in use

                if (_sslProperties.usingSSL()) {
                                 ...
                                 try {
                                                  SSLContext sslContext = ...
                                                  _serverSocket = ...
                                 } catch (Exception e) {
                                                  // don't display exceptions 193426
                                                  //e.printStackTrace();
                                                  System.err.println(e.getMessage());
                                                  System.exit(-1);
                                 }
                }

I find neither the System.err.println() nor the System.exit()
here not compliant with general Eclipse practice. This
terminates the entire JVM! Open editors will be lost! Is
this really what we want?

I'm not tagging this for today's I-build unless you clarify.

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm