[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
[dsdp-tm-dev] RC1 Code Review - Refresh
|
Hi Dave,
I reviewed yesterday's changes and I have some questions
and requests:
* SystemCommonDeleteAction:
you added e.printStackTrace()
We should avoid this wherever possible. Errors should
be logged instead of printing to stdout.
* SystemView.EVENT_REFRESH_REMOTE:
[187732] can only do the reget of "remote" items
You added if(getRemoteAdapter(src)!=null)
This is a very dangerous change IMHO and may break our
commercial product... is there really a need to implement
ISystemRemoteElementAdapter? Wouldn't it be sufficient
to implement IRemoteObjectIdentifier or ISystemViewElementAdapter?
We do not implement ISystemRemoteElementAdapter in our commercial
product, and we filed some bugs because of this earlier.
That's why a lot of code in SystemView now uses the
SYstemViewElementAdapter rather than ISystemRemoteElementAdapter.
But perhaps I'm misunderstanding things?
My concept of something being "Remote" is if
1.) It implements ISystemRemoteObjectIdentifier
2.) It is associated with a subsystem
adapter.getSubSystem(Object) != null
What do you think?
Can you please answer and/or address these.
Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm