[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [dsdp-tm-dev] RC1 Code Review - persistence
|
Yes,
I know it's implicit for interfaces but still I
find it more readable to have it ther. It's not
a big deal though.
Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: dsdp-tm-dev-bounces@xxxxxxxxxxx
> [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of David Dykstal
> Sent: Friday, May 25, 2007 4:54 PM
> To: Target Management developer discussions
> Subject: Re: [dsdp-tm-dev] RC1 Code Review - persistence
> Importance: High
>
> Done.
>
> Interface members are automatically public so I didn't think it was
> necessary to have the public declaration. Is this something
> we should
> be doing by convention?
>
> -- Dave
>
> On May 25, 2007, at 6:40 AM, Oberhuber, Martin wrote:
>
> > Hi Dave,
> >
> > I reviewed yesterday's changes and I have some questions
> > and requests:
> >
> > * IRSEPersistableContainer.NO_CHILDREN
> > should be explicitly declared public
> > and please add Javadoc for it
> >
> > * ISystemProfile.setActive()
> > Javadoc: can you explain what the "active" state means?
> >
> > * ISystemProfileManager.getActiveSystemProfilePosition()
> > You deprecated this. Whenever you deprecate something,
> > please leave a note what other mechanism the client can
> > use to accomplish what used to be accomplisehd by that
> > method!
> >
> > * PropertyList, RSEPersistableObject, Messages.java:
> > Please use the "Fix Copyrights" tool. It has a slightly
> > different default comment format built in than you are
> > using. We should have a consistent comment format everywhere.
> >
> > Can you please answer and/or address these.
> >
> > Thanks,
> > --
> > Martin Oberhuber
> > Wind River Systems, Inc.
> > Target Management Project Lead, DSDP PMC Member
> > http://www.eclipse.org/dsdp/tm
> > _______________________________________________
> > dsdp-tm-dev mailing list
> > dsdp-tm-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
>
> _______________________________________________
> dsdp-tm-dev mailing list
> dsdp-tm-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
>
