[dsdp-tm-dev] RC1 Code Review

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hi Michael,

I reviewed your code changes for
https://bugs.eclipse.org/bugs/show_bug.cgi?id=188939 
And I have some questions:

TerminalConnectorExtension.getConnector():
1. You store the RuntimeException inside fException
   and if one exists, the connector is treated as
   initialized. Should there perhaps be a mechanism
   that allows for dynamic reconfiguring, i.e. fixing
   a not installed problem? This might be worth a 
   separate bug entry for the future.

2. You seem to be wrapping the RuntimeException 
   inside another RuntimeException, doesn't this
   hide the embedded message for later processing
   in TerminalControl?

TerminalControl:
1. When displaying the RuntimeException, is it guaranteed
   that all exceptions have a message? I often do this:

   String msg = e.getMessage();
   if (msg==null) msg = e.getClass().getName();

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm