Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tm-dev] New FTP Listing Parser Extension Point
Hello Javier,

two more considerations:
  • We should avoid having to activate plugins which contribute FTP parsers, just in order to check whether they are valid. Therefore, the extension point should have another attribute "systemNames" which should contain a regular _expression_ that needs to match the system name reported by the remote side. If it matches, AUTO would activate the plugin, instantiate the parser, and try that parser on that system.
  • If I'm not mistaken, the original idea of the "services" layer in RSE was that it should also work without Eclipse. Therefore, the Services layer should not have references to the Extension Point mechanism. Instead, the FTP Subsystem should do the Extension Point Parsing and pass the IFTPListingParserProxy objects into the FTP Service in order to register them with the service.
Other comments from the Community?

Cheers,
Martin


Oberhuber, Martin schrieb: 
Hello Javier,
 
I looked at your patch and it looks good to me.
 
I have no time right now to test it with VxWorks, but I'm confident
that it will work fine. Your patch looks sizeable, so please go ahead
and commit it.
 
What I would like to see going forward, is the ability that the 
"AUTO" parser type also tries the various contributed parsers.
Right now, when I'm not mistaken, any extender-contributed
parser will only be used when explicitly selected by the user.
 
This is not user-friendly. We should allow extenders to contribute
parsers, but the system should be able to select the contributed
parsers automatically wherever possible. In the simplest case, 
the parser contribution could have an 
   boolean isValidFor(String systemType)
method that allows auto-selecting it based on the systemType
returned by the remote. In case multiple contributed parsers
return TRUE for isValidFor(), they could be tried one after the
other while parsing, until the first one is successful.
 

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm <http://www.eclipse.org/dsdp/tm>  
  

-- 
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm

Back to the top