Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [dsdp-tm-dev] RE: Making stuff internal

Very right Kushal, thanks for the hint.

options.txt drives the Javadoc compilation, and
holds a classpath for the packages to be indexed.
Having obsolete package names there won't be visible,
but as a matter of cleanup it's better to get rid 
of them.

I removed the following packages which are now internal from
options.txt:
------------------------------------------------------------------------
-
org.eclipse.rse.connectorservice.ssh
org.eclipse.rse.services.ssh
org.eclipse.rse.services.ssh.files
org.eclipse.rse.services.ssh.shell
org.eclipse.rse.subsystems.files.ssh
org.eclipse.rse.subsystems.shells.ssh

org.eclipse.rse.services.files.ftp
org.eclipse.rse.subsystems.files.ftp
org.eclipse.rse.subsystems.files.ftp.connectorservice
org.eclipse.rse.subsystems.files.ftp.model

org.eclipse.rse.ui.view.monitor
org.eclipse.rse.ui.view.scratchpad
org.eclipse.rse.ui.view.search
org.eclipse.rse.ui.view.team

and also the following classpath entries for
plugins, which now have only internal packages:
-----------------------------------------------
;../org.eclipse.rse.connectorservice.ssh/src
;../org.eclipse.rse.services.ssh/src
;../org.eclipse.rse.subsystems.files.ssh/src
;../org.eclipse.rse.subsystems.shells.ssh/src

;../org.eclipse.rse.services.files.ftp/src
;../org.eclipse.rse.subsystems.files.ftp/src

and the following from topics_Reference.xml:
---------------------------------------------
			<topic
label="org.eclipse.rse.services.files.ftp"
href="reference/api/org/eclipse/rse/services/files/ftp/package-summary.h
tml"/>
			<topic
label="org.eclipse.rse.subsystems.files.ftp.connectorservice"
href="reference/api/org/eclipse/rse/subsystems/files/ftp/connectorservic
e/package-summary.html"/>
			<topic
label="org.eclipse.rse.subsystems.files.ftp.model"
href="reference/api/org/eclipse/rse/subsystems/files/ftp/model/package-s
ummary.html"/>
			<topic
label="org.eclipse.rse.subsystems.files.ftp"
href="reference/api/org/eclipse/rse/subsystems/files/ftp/package-summary
.html"/>

			<topic label="org.eclipse.rse.ui.view.monitor"
href="reference/api/org/eclipse/rse/ui/view/monitor/package-summary.html
"/>
			<topic
label="org.eclipse.rse.ui.view.scratchpad"
href="reference/api/org/eclipse/rse/ui/view/scratchpad/package-summary.h
tml"/>
			<topic label="org.eclipse.rse.ui.view.search"
href="reference/api/org/eclipse/rse/ui/view/search/package-summary.html"
/>
			<topic label="org.eclipse.rse.ui.view.team"
href="reference/api/org/eclipse/rse/ui/view/team/package-summary.html"/>

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm 

> -----Original Message-----
> From: dsdp-tm-dev-bounces@xxxxxxxxxxx 
> [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of Kushal Munir
> Sent: Friday, February 16, 2007 7:14 PM
> To: Target Management developer discussions
> Subject: Re: [dsdp-tm-dev] RE: Making stuff internal
> 
> Hi Martin,
> 
> Thanks for the tips. Regarding this point:
> 
> * Do a text search for the old package name that's now removed
>   --> you'll find rse.doc.isv/topics_Reference.xml
>   --> Remove the now internal packages from there
> 
> How about org.eclipse.rse.doc.isv/options.txt? I think the 
> javadoc in the
> build uses this file, so we should probably remove packages 
> from there as
> well, although I guess it probably just won't find the package.
> 
> Cheers,
> 
> Kushal Munir
> Websphere Development Studio Client for iSeries
> IBM Toronto Lab, 8200 Warden Ave., Markham, ON
> Phone: (905) 413-3118        Tie-Line: 969-3118
> Email: kmunir@xxxxxxxxxx
> 
> 
> 
>                                                               
>              
>              "Oberhuber,                                      
>              
>              Martin"                                          
>              
>              <Martin.Oberhuber                                
>           To 
>              @windriver.com>           "Target Management 
> developer        
>              Sent by:                  discussions"           
>              
>              dsdp-tm-dev-bounc         
> <dsdp-tm-dev@xxxxxxxxxxx>           
>              es@xxxxxxxxxxx                                   
>           cc 
>                                                               
>              
>                                                               
>      Subject 
>              02/15/2007 10:47          [dsdp-tm-dev] RE: 
> Making stuff      
>              AM                        internal               
>              
>                                                               
>              
>                                                               
>              
>              Please respond to                                
>              
>              Target Management                                
>              
>                  developer                                    
>              
>                 discussions                                   
>              
>              <dsdp-tm-dev@ecli                                
>              
>                  pse.org>                                     
>              
>                                                               
>              
>                                                               
>              
> 
> 
> 
> 
> Hi all,
> 
> Here is some more help for making things internal
> (basically, what worked for me):
> 
> * Before you start, make sure your workspace is up-to-date
>   (select projects , Team > Update)
> 
> * Select the package to make internal, Right click >
>   Refactor > Rename
>   - Enter new name
>   - Make sure all checkboxes are ticked
>     - Filename patterns: use at least *.xml,*.properties,*.mf
> 
> * In the Review Wizard: An Activator often has the
>   PLUGIN_ID, this one must NOT be refactored so disable it
>   - Most others must be refactored
> 
> * When the Rename is done, select the MANIFEST.MF and choose
>   PDE Tools > Organize Manifests... in order to mark the
>   now-internal packages with ;x-internal=true;
>   - enable all except those tagged (this may be a long-running...)
>   - also disable the last-but-one (extensions with $nl$ segment)
> 
> * In case you have cross-dependencies e.g. services.ftp ->
>   subsystems.ftp: in the services.ftp manifest.mf, export the
>   internal packages with ;x-friends:="org.eclipse..."
>   --> See what I have done for ssh
> 
> * In those plugins that use now-refactored internal classes,
>   do PDE Tools > Update Classpath and review the resulting
>   .classpath file -- Access rules for marking **/internal/**
>   as discouraged access should be removed by this.
> 
> * Do a text search for the old package name that's now removed
>   --> you'll find rse.doc.isv/topics_Reference.xml
>   --> Remove the now internal packages from there
> 
> * Before checking in, review the Copyright headers and make
>   sure that all now-moved Java files have , 2007 in the
>   copyright year (can at least partially be done by search
>   + replace; if it's many files you may want to check in
>   before making this copyright change)
> 
> * When checking in, select all projects, choose Team > Commit
>   - Do not use the Synchronize view, you might miss those
>     packages that have been removed
> 
> Cheers,
> --
> Martin Oberhuber
> Wind River Systems, Inc.
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
> _______________________________________________
> dsdp-tm-dev mailing list
> dsdp-tm-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> 
> 
> _______________________________________________
> dsdp-tm-dev mailing list
> dsdp-tm-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> 


Back to the top