Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [dsdp-tm-dev] Request for API change: systemType icon properties

PS:

Actually, the fallback to using the <property> markup
for the icons would come in automatically, since I
wouldn't change the internal representation, so the
"enableOffline", "icon" and "iconLive" properties
would still be supported.

Cheers,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm 

> -----Original Message-----
> From: dsdp-tm-dev-bounces@xxxxxxxxxxx 
> [mailto:dsdp-tm-dev-bounces@xxxxxxxxxxx] On Behalf Of 
> Oberhuber, Martin
> Sent: Thursday, August 24, 2006 5:43 PM
> To: David Dykstal; David McKnight; Kushal Munir
> Cc: Target Management developer discussions
> Subject: [dsdp-tm-dev] Request for API change: systemType 
> icon properties
> 
> Dear committers,
> 
> I would like to request an API change in the systemTypes 
> extension point:
> 
> In RSE 7 and before, the icon of a systemType was specified
> as a String property. For openRSE, this has been changed to
> put the icon references into a <property> markup.
> 
> The disadvantages of this are, that
>  * It is not obvious that icons are required by the code
>  * PDE cannot be used to browse for the icon resource
>    in the extension point schema editor
>  * PDE cannot display the icon in the plugin.xml editor
>  * The extension point looks more complex than necessary
>  * There is unnecessary extra migration effort from RSE7
> 
> I would therefore like to revert to the original structure,
> and pass "icon" and "iconLive" in as attributes. I would
> like to keep the <property> markup there, in order to 
> support custom extensions later on.
> 
> If you want, the code could also make a fallback to reading
> the icon from <property> if it is not available in the "icon"
> attribute; but I don't think this is necessary since there is
> no released version of this right now.
> 
> Any comments on the request?
> Can we please vote on this request?
> 
> Thanks,
> --
> Martin Oberhuber
> Wind River Systems, Inc.
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm 
> _______________________________________________
> dsdp-tm-dev mailing list
> dsdp-tm-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tm-dev
> 


Back to the top