Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tm-dev] encoding typo ?


Hi,

I had problems opening the Local Shell, so after looking at the code I found what could be a typo in setting the encoding of the streams.
I got this issue because I'm running on Win2K. Running on WinXP won't reproduce the error as the following if block is not entered.

The patch would be:


### Eclipse Workspace Patch 1.0
#P org.eclipse.rse.services.local
Index: src/org/eclipse/rse/internal/services/local/shells/LocalShellThread.java
===================================================================
RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.services.local/src/org/eclipse/rse/internal/services/local/shells/LocalShellThread.java,v
retrieving revision 1.1
diff -u -r1.1 LocalShellThread.java
--- src/org/eclipse/rse/internal/services/local/shells/LocalShellThread.java        10 Apr 2006 20:47:45 -0000        1.1
+++ src/org/eclipse/rse/internal/services/local/shells/LocalShellThread.java        26 Apr 2006 11:32:33 -0000
@@ -259,8 +259,8 @@
 
                         if (_encoding.equals("Cp1252") && !theOS.startsWith("Windows XP"))
                         {
-                                _stdInput = new BufferedReader(new InputStreamReader(_theProcess.getInputStream(), "Cp850"));
-                                _stdError = new BufferedReader(new InputStreamReader(_theProcess.getErrorStream(), "Cp850"));
+                                _stdInput = new BufferedReader(new InputStreamReader(_theProcess.getInputStream(), "Cp1252"));
+                                _stdError = new BufferedReader(new InputStreamReader(_theProcess.getErrorStream(), "Cp1252"));
                         }
                         else
                         {

If you agree, I'll open a bugzilla entry for it.

Cheers,

Javier Montalvo OrĂºs
Engineering Tools
Symbian Software Limited.

Tel: +44 (0)207 154 1091




*******************************************************************
*** Symbian Software Ltd is a company registered in England and
Wales with registered number 4190020 and registered office at 2-6
Boundary Row, Southwark, London, SE1 8HP, UK. This message is
intended only for use by the named addressee and may contain
privileged and/or confidential information. If you are not the
named addressee you should not disseminate, copy or take any action
in reliance on it. If you have received this message in error
please notify postmaster@xxxxxxxxxxx and delete the message and any
attachments accompanying it immediately. Neither Symbian nor any of
its Affiliates accepts liability for any corruption, interception,
amendment, tampering or viruses occurring to this message in
transit or for any message sent by its employees which is not in
compliance with Symbian corporate policy. *************************
*********************************************


Back to the top