[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[dsdp-tcf-dev] [Bug 316073] New: [patch] MinGW/MSVC fixes for crash in TCF reference agent
|
https://bugs.eclipse.org/bugs/show_bug.cgi?id=316073
Product/Component: Target Management / TCF
Summary: [patch] MinGW/MSVC fixes for crash in TCF reference
agent
Classification: DSDP
Product: Target Management
Version: 3.2
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: critical
Priority: P3
Component: TCF
AssignedTo: dsdp.tm.tcf-inbox@xxxxxxxxxxx
ReportedBy: ed.swartz@xxxxxxxxx
QAContact: martin.oberhuber@xxxxxxxxxxxxx
Ed Swartz <ed.swartz@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #171359| |review?
Flag| |
Created an attachment (id=171359)
--> (https://bugs.eclipse.org/bugs/attachment.cgi?id=171359)
update to replace %ll* with macros
Due to some trace() logging for peers with invalid timestamps
(discovery_udp.c:udp_receive_ack_slaves), we are seeing nearly immediate
crashes of TCF agents built with MinGW. (Apparently in our office we have a
ton of dead TCF agents still kicking about. ;)
In MinGW and MSVC, the interpretation in printf of "%lld" and "%llX" is "%u"
and "%x" (for legacy compatibility, pre-C99). So formatting this value
(actually, any "%s" values after it) causes crashes in vfprintf().
This patch, thusly, replaces uses of "%lld" and "%llX" with macros that adapt
to the build environment.
Note: I only tested this build on MinGW. It would be good if someone tested it
on MSVC to double-check. I did verify it doesn't break the Cygwin build.
And please feel free to rename the macros... they are a bit wordy.
--
Configure bugmail: https://bugs.eclipse.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
