Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tcf-dev] [Bug 311759] Patches for Symbian TCF agent porting support

https://bugs.eclipse.org/bugs/show_bug.cgi?id=311759 
Product/Component: Target Management / TCF

Eugene Tarassov <eugene.tarassov@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |eugene.tarassov@windriver.c
                   |                            |om
         Resolution|                            |FIXED

--- Comment #1 from Eugene Tarassov <eugene.tarassov@xxxxxxxxxxxxx> 2010-05-05 19:19:04 EDT ---
I have committed the patch, with few minor changes: 

in trace.c:
removed RDEBUG_TRACE - it seems not needed since you can log to stderr if you
call open_log_file("-") or use -L- option in the agent command line.

in mdep.c:
reused Windows/VxWorks implementation of pread/pwrite since it is identical to 
Symbian implementation.

in asyncreq.c:
req->error should be assigned before calling trace(), because the call can
overwrite errno, also not sure why errno was printed two times, so I changed
the code to print it only once.

Thanks.

-- 
Configure bugmail: https://bugs.eclipse.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.


Back to the top