Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tcf-dev] [Bug 301192] New: Calls into IServiceProvider should use SafeRunner 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=301192 
Product/Component: Target Management / TCF

           Summary: Calls into IServiceProvider should use SafeRunner
    Classification: DSDP
           Product: Target Management
           Version: unspecified
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P3
         Component: TCF
        AssignedTo: dsdp.tm.tcf-inbox@xxxxxxxxxxx
        ReportedBy: john.cortell@xxxxxxxxxxxxx
         QAContact: martin.oberhuber@xxxxxxxxxxxxx


ServiceManager.onChannelOpened() calls into IServiceProviders, some of which
are contributed by clients. I believe the call should be guarded using a
SafeRunner so that an assertion failure in client code doesn't close the
channel. After all, the code is just trying to get a proxy for a given service.
An assertion failure there should be recorded in the error log. Closing the
channel seems pretty extreme, not to mention the reason for it closing is not
exposed to the developer at all. 

Other instances where IServiceProvider is called should be searched for,
inspected and guarded (with SafeRunner) where it makes sense.

-- 
Configure bugmail: https://bugs.eclipse.org/bugs/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

Back to the top