RE: [dsdp-tcf-dev] [Trivial PATCH] Fix protocol peer reply tracesegfault

["Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>]

Hi Ed,

many thanks for noticing this problem and letting us know -
thanks Eugene for applying so quickly.

May I still remind us all that as a matter of Eclipse Policy,
we usually cannot accept patches from any source other than
bugzilla alone. This is because of tracking as well as a
safeguard in terms of Copyright law due to the Eclipse Website
terms of use which apply to Bugzilla.

I do not believe that a change of a single character could
ever lead to Copyright or patent issues, because that single
character does not comprise any kind of artistic expression
(which is what Copyright law protects). But then I'm not a 
lawyer, and who knows.

So my point here is just, that filing a bugzilla bug is not
at all more effort than sending this E-Mail. A hyperlink for
getting a TCF bug entry template is on the TCF FAQ:

  https://bugs.eclipse.org/bugs/enter_bug.cgi?component=TCF&form_name=enter_bug&product=Target%20Management

In my firefox installation, I have a bookmark for this under
a bookmarks folder called "Bugs" in the toolbar. So what I do
when I find a TCF problem is just go to the Firefox toolbar
> Bugs > TCF New. Then I enter a summary, and attach the patch.
Done! Not more effort than E-Mail + clicking Send.

Let's use this process even for simple things -- the added
benefits include
  - ability to discuss the issue in an organized fashion
  - clear status for issue if not possible to react immediately
  - having the issue searchable
  - public record of contributions and contributors

Thanks,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
 
 

> -----Original Message-----
> From: dsdp-tcf-dev-bounces@xxxxxxxxxxx 
> [mailto:dsdp-tcf-dev-bounces@xxxxxxxxxxx] On Behalf Of 
> Tarassov, Eugene
> Sent: Donnerstag, 05. März 2009 10:55
> To: DSDP TCF dev list
> Subject: RE: [dsdp-tcf-dev] [Trivial PATCH] Fix protocol peer 
> reply tracesegfault
> 
> Fixed.
> Thanks,
> Eugene 
> 
> -----Original Message-----
> From: dsdp-tcf-dev-bounces@xxxxxxxxxxx
> [mailto:dsdp-tcf-dev-bounces@xxxxxxxxxxx] On Behalf Of Ed Swarthout
> Sent: Wednesday, March 04, 2009 9:15 PM
> To: dsdp-tcf-dev@xxxxxxxxxxx
> Subject: [dsdp-tcf-dev] [Trivial PATCH] Fix protocol peer reply trace
> segfault
> 
> Index: agent/protocol.c
> ===================================================================
> --- agent/protocol.c	(revision 633)
> +++ agent/protocol.c	(working copy)
> @@ -244,7 +244,7 @@
>      else if (type[0] == 'R' || type[0] == 'P' || type[0] == 'N') {
>          Trap trap;
>          read_stringz(&c->inp, token, sizeof(token));
> -        trace(LOG_PROTOCOL, "Peer %s: Reply: %c %s ...", type[0],
> c->peer_name, token);
> +        trace(LOG_PROTOCOL, "Peer %c: Reply: %s %s ...", type[0], 
> + c->peer_name, token);
>          if (set_trap(&trap)) {
>              ReplyHandlerInfo * rh = NULL;
>              char * endptr = NULL;
> _______________________________________________
> dsdp-tcf-dev mailing list
> dsdp-tcf-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tcf-dev
> _______________________________________________
> dsdp-tcf-dev mailing list
> dsdp-tcf-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-tcf-dev
>