Re: [dsdp-mtj-dev] Symbol Set definition from antenna

[Feng.Wang@xxxxxxxxxx]

Hi Ales,

Thank you for your patch. I tested it.
It works well and looks great. I add some comments on the bugzilla entry:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=253860

Best Regards,
Feng(Marvin) Wang(王峰)

Sybase Software (China) Co., Ltd
Room 1202-1203, Building One, 
Zhangjiang Semiconductor Industry Park
3000 Longdong Avenue
Pudong, Shanghai 201203
Tel: +8621-38657441 or 258-7441
email: feng.wang@xxxxxxxxxx

"Ales Milan (Inlogic Software s.r.o.)" <amilan@xxxxxxxxxx>
Sent by: dsdp-mtj-dev-bounces@xxxxxxxxxxx

2008-11-24 20:44

Please respond to
Mobile Tools for The Java Platform mailing list        <dsdp-mtj-dev@xxxxxxxxxxx>

To	Mobile Tools for The Java Platform mailing list <dsdp-mtj-dev@xxxxxxxxxxx>
cc
Subject	Re: [dsdp-mtj-dev] Symbol Set definition from antenna

I attach patch for import functionality. Craig (or whoever),
please could you have look on that. 
My understanding is that MVC pattern is everywhere. So, I'm not sure if
my patch is useful and I can continue to do export functionality and documentation
to added sources.

I did simple import wizard. Import functionality is included in wizarddialog..
more info see https://bugs.eclipse.org/bugs/show_bug.cgi?id=253860

On Sun, 2008-11-23 at 12:24 -0600, Craig Setera wrote:
The XMLPersistenceProvider is used in multiple placed
and would have to be handled carefully to avoid issues elsewhere.  That
isn't to say that it can't be done, but will require careful changes and
testing.  The other option would be to alter the persistence provider
code to do an encoding of the "/" in the key name to avoid the
problem and then a special case to decode that value.


Ales Milan (Inlogic Software s.r.o.) wrote: 
Hi Guys,

I'm implementing import/export definitionSet, but when I want to save imported
definition set there is problem in XML format.
Key value is used as tag name, what is wrong, because Key value can contains
character "/". This character as we know is not allowed for XML
doc. 
Currently symbolDefinitions.xml format look like:

<symbolDefinitionsRegistry version="0.9.0.qualifier">
   <MediaControlSkin class="org.eclipse.mtj.core.model.preprocessor.SymbolDefinitionSet"
id="0">
      <mtjName value="MediaControlSkin"/>
      <MMAPI value="1.1"/>
      <JSR82 value="1.0"/>
...

Better:

<symbolDefinitionsRegistry version="0.9.0.qualifier">
   <MediaControlSkin class="org.eclipse.mtj.core.model.preprocessor.SymbolDefinitionSet"
id="0">
      <mtjName value="MediaControlSkin"/>
      <definition name="MMAPI" value="1.1"/>
      <definition name="JSR82" value="1.0"/>

Can I change this XMLPersistenceProvider provider?  I'm not sure if
this provider is used only for storing definitionSet or if is used for
core config as well.
Next question, If I change format, what I have to do with backward compatibility?
We should support that...

Current status:
I did import wizard, where user can choice to import definition set from
a) antenna jar file
b) from J2ME polish files (devices.xml, groups.xml)
c) import from MTJ format -> this format is used for importing exported
definition set. MTJ will be export definitionSet to own format.
any comments?

Thanks.
Ales


On Thu, 2008-11-13 at 15:32 -0800, Christian Kurzke wrote: 

Hi Ales,

Gustavo already gave you all the right technical answers, describing the
high level process.

Please feel free to implement the feature, if you need any help to 
understand the code, use this mailing list, and we'll help you as much
as we can.
If you find areas that are not well documented, feel free to add 
comments as well!  :-)


Once you have tested your code, and want to submit it, the process is 
that - you cannot check it into SVN directly.
You will have to create the patch and submit it using "Eclipse Bugzilla".

If you have any problems understanding the process - please ask for help
here!



One overall suggestion I want to make for this: Since you mentioned that
you have not contributed to an Open Source project,
please let me highlight one particular important issue:

Copyright and Intellectual Property.

There is two main concerns.

1) Eclipse Code (which includes MTJ) is created under the the terms of
the "Eclipse Public License" (EPL).
Basically this means:  Whatever code you write and contribute will
be 
re-distributed under this license, and when you
submit the "patch" using Bugzilla, you will have to agree to
the "terms 
and conditions" of the EPL.

The EPL is a very "friendly" license and restricts in no way
what you 
yourself can do with your work.

The only "problem" is - The EPL is not compatible with the GNU
Public 
License (GPL).

Therefore - if you use any other code in your Patch - for example, you
"Copy and Paste" an example from an
online tutorial, or you "copy and paste" from an other Open Source
software....
.... you have to be VERY careful that you do not violate any license.

My recommendation: *Please do NOT copy and paste from any other code/text.*

IF you need any other software, e.g. libraries etc, please let us know,
we can discuss it, and with the help of Eclipse
Legal team decide to use those libraries.

We all are working VERY hard to keep the Eclipse source code free from
any code which is not compatible with the EPL.



2) Your Employer: Please do also NOT re-use any code which you have 
created as part of your "employment", for your
"real" job.
Your employer typically has policies and procedures how you can 
contribute to Open Source.
Please make sure you know and follow all your employers processes.


I hope this is helpful for you, and WELCOME to the project!
:)


-Christian




Ales Milan (Inlogic Software s.r.o.) wrote:
> Yes, I want to help with this part, but I never code opensource. So
> please help me to start :)
> How I can join to commiters? Do I need to continue through 
> http://www.eclipse.org/membership/become_a_member/
page?
>
> I download source code from SVN. Import project to eclipse and tried
> to make some changes... Everything works fine. I'm ready to help..
So, 
> where is I can get some documentation about source code of MTJ? What
> is where, etc.
>
> Ales
>
>
> On Thu, 2008-11-13 at 11:37 -0500, Paula Gustavo-WGP010 wrote:
>> Hi ales,
>>
>>  
>>
>> Code is always welcome J if you have time to do this please let
us 
>> know. We are also trying to find some resources to do this feature
on 
>> 0.9.1 scope
>>
>>  
>>
>> Regards,
>>
>> gustavo
>>
>>  
>>
>> ------------------------------------------------------------------------
>> *De:*dsdp-mtj-dev-bounces@xxxxxxxxxxx
>> [mailto:dsdp-mtj-dev-bounces@xxxxxxxxxxx]
*Em nome de *Ales Milan 
>> (Inlogic Software s.r.o.)
>> *Enviada em:* quinta-feira, 13 de novembro de 2008 05:54
>> *Para:* dsdp-mtj-dev@xxxxxxxxxxx
>> *Assunto:* Re: [dsdp-mtj-dev] Symbol Set definition from antenna
>>
>>
>>  
>>
>> This thing it's quite important for me. I could to do this stuff...
>> I really would like to switch to MTJ. This is still my brake.
>>
>> Ales
>>
>>
>> _______________________________________________
>> dsdp-mtj-dev mailing list
>> dsdp-mtj-dev@xxxxxxxxxxx
<mailto:dsdp-mtj-dev@xxxxxxxxxxx>
>> https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev
>>     
> *//Ales Milan*              
   Head of Experiments
> ------------------------------------------------------------------------
>                  *Inlogic
Software s.r.o*
> http://www.inlogic.sk/
> Partizanska cesta 97
> Banska Bystrica
> 974 01
> Slovakia
>
>
> email:                
  amilan@xxxxxxxxxx
> mobil:                
  +421 905 473 873
> tel./fax:              
    +421 55 642 4753
> icq:                
  89027016
>
>
>
>
>                  www.playamo.com
>
>
>                  www.playonway.com
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> dsdp-mtj-dev mailing list
> dsdp-mtj-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev
>   

_______________________________________________
dsdp-mtj-dev mailing list
dsdp-mtj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev

---

_______________________________________________
dsdp-mtj-dev mailing list
dsdp-mtj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev
  


_______________________________________________
dsdp-mtj-dev mailing list
dsdp-mtj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev
_______________________________________________
dsdp-mtj-dev mailing list
dsdp-mtj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dsdp-mtj-dev