Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [Dltk-dev] DLTK 5.6 part of Neon.1

Thanks for the confirmation.

I merged the patch and promoted it to the nightly update site.

The patch will be included in Neon.1 RC2.

Thierry, you can abandon you patches for DLTK and PDT.

Kaloyan

On 08/26/2016 12:13 PM, Simon Bernard wrote:

The build is ok with this update site.


Le 26/08/2016 à 10:53, Kaloyan Raev a écrit :
Simon,

Try this URL for the update site:
https://hudson.eclipse.org/dltk/job/dltk.core-gerrit/313/artifact/org.eclipse.dltk.releng/build/update.site/target/repository/

Kaloyan

On 08/26/2016 11:50 AM, Simon Bernard wrote:
This seems to compile in eclipse. (I can not really build the project with maven/tycho as I can't find any updatesite with this patch ? Please, tell me when an updatesite will be available)

Thx :)

Simon

Le 26/08/2016 à 09:37, Kaloyan Raev a écrit :
Thank you, Dawid!

Simon, could you confirm that this patch resolves your issue?

Kaloyan

On 08/25/2016 11:54 PM, Dawid Pakuła wrote:
Hi,

I moved all dltk.core bundles to Java 1.8, so a lot of files was changed. Real change is inside IParameter.

-- 
Dawid Pakuła

From: Kaloyan Raev <kaloyan.r@xxxxxxxx>
Reply: DLTK Developer Discussions <dltk-dev@xxxxxxxxxxx>
Date: 25 August 2016 at 09:01:36
To: thierry blind <thierryblind@xxxxxxx>, DLTK Developer Discussions <dltk-dev@xxxxxxxxxxx>
Subject:  Re: [Dltk-dev] DLTK 5.6 part of Neon.1

Hi Thierry,

The patch you implemented was my initial suggestion. But Dawid proposed a better approach using default methods (Java 8 feature). As he replied, he will try contributing a patch with this approach.

If default methods work out then no change should be required in PDT.

Kaloyan

On 08/24/2016 10:54 PM, thierry blind wrote:
Hi Kaloyan,
something like that?
https://git.eclipse.org/r/#/c/79661

If ok, merge it asap please, as PDT code has to be updated afterwards ;)

Thierry.


Subject: Re: [Dltk-dev] DLTK 5.6 part of Neon.1
To: dltk-dev@xxxxxxxxxxx; thierryblind@xxxxxxx
From: kaloyan.r@xxxxxxxx
Date: Wed, 24 Aug 2016 17:16:45 +0300

Hi Thierry,

This change was introduced by a patch of yours.

Could you re-work it to be backward compatible for Neon.1 RC2?

I believe this can be achieved by introducing the getFlags() method in a new interface IParameter2 that extends the old (and untouched) IParameter interface. This way we will have the old IParameter interface untouched for those need the backward compatibility and the new IParameter2 for those who need the new functionality.

Kaloyan

On 08/23/2016 06:15 PM, Simon Bernard wrote:
Hi there is an API break in DLTK 5.6.

I talked about the add of getFlags() on IParameter.
https://git.eclipse.org/c/dltk/org.eclipse.dltk.core.git/commit/?id=b0517331fc42d2c7029477fc55611316da1750c2

Could we avoid this API break for both Oxygen and Neon.
(In all case for Neon this seems to me mandatory to not break the API)

Thx
Simon

Le 09/08/2016 à 15:59, Kaloyan Raev a écrit :
Hi,


I've declared DLTK 5.6 M1: 
http://download.eclipse.org/technology/dltk/updates-dev/milestone/5.6m1/



I contributed it to both the Oxygen and Neon.1 simrel builds.


Kaloyan

From: dltk-dev-bounces@xxxxxxxxxxx <dltk-dev-bounces@xxxxxxxxxxx> on behalf of Dawid Pakuła <zulus@xxxxxxxxx>
Sent: Monday, August 8, 2016 11:03:56 AM
To: DLTK Developer Discussions
Subject: Re: [Dltk-dev] DLTK 5.6 part of Neon.1
 
Hi,

thanks! After DLTK declare I’ll promote PDT builds.

-- 
Dawid Pakuła

From: Kaloyan Raev <kaloyan.r@xxxxxxxx>
Reply: DLTK Developer Discussions <dltk-dev@xxxxxxxxxxx>
Date: 8 August 2016 at 09:15:32
To: DLTK Developer Discussions <dltk-dev@xxxxxxxxxxx>
Subject:  Re: [Dltk-dev] DLTK 5.6 part of Neon.1

Hi Dawid,


Of course, DLTK 5.6 will be part of Neon.1.


The Checkpoint was mandatory only for *new* projects in the release train.


Tomorrow is the Oxygen M1 +2 date. I will declare the DLTK 5.6 M1 milestone. I will contribute it to both the Oxygen and Neon.1 simrel builds.


Two weeks later is the Neon.1 RC1 +2 date. I will declare the DLTK 5.6 RC1 milestone and contribute it to the Neon.1 simrel build.


The same can be done for PDT on the respective +3 dates.


Sounds good?
Kaloyan

From: dltk-dev-bounces@xxxxxxxxxxx <dltk-dev-bounces@xxxxxxxxxxx> on behalf of Dawid Pakuła <zulus@xxxxxxxxx>
Sent: Sunday, August 7, 2016 10:24:28 PM
To: DLTK Developer Discussions
Subject: [Dltk-dev] DLTK 5.6 part of Neon.1
 
Hi,

I hope DLTK 5.6 will be part of Neon.1, without it we cannot promote PDT 4.1 to Neon.1 simrel.

We are behind checkpoint, next Neon.1 build will be RC1.

-- 
Dawid Pakuła
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/dltk-dev



_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/dltk-dev

--
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx

--
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/dltk-dev


_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/dltk-dev

--
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx



_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/dltk-dev

--
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx



_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/dltk-dev

--
Kaloyan Raev | Zend Studio Team Lead
Rogue Wave Software, Inc.
Accelerating Great Code
M +359 887 648 663
www.roguewave.com / kaloyan.raev@xxxxxxxxxxxxx

Back to the top