Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [Dltk-dev] DelegatingFoldingStructure and IFoldingBlockProvider

Hi Edgar,

DelegatingFoldingStructure is used in DLTK-_javascript_ Editor and a couple of other projects.

1 & 2 are basically the same issue.
To resolve you should report correct values for "IFoldingBlockKind kind, Object element" parameters - they are like the primary key of the region, so they should have correct equals() implementation, etc.

NPE is unexpected, it can occur only if code is executed in another thread. It is called by the reconciler, so the only assumption is that another reconciler is started somehow for the same editor.

Regards,
Alex

----- Original Message -----
From: "Edgar Espina" <espina.edgar@xxxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Sent: Monday, July 12, 2010 7:54:22 PM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] DelegatingFoldingStructure and IFoldingBlockProvider

Greetings,

 I'm writing some parts (actually all the code :D) from my ANTLR IDE. Starting with DLTK2.0 the AbstractASTFoldingStructureProvider class was deprecated in favor of DelegatingFoldingStructure and IFoldingBlockProvider which is good. The default implementation PartitionIdFoldingProvider does a great work integrating the folding regions with the already created partitions.
 I would like to know if anyone is using these new two classes, because I found three issues:
  1) The initial collapse could not be ensured. If I set the initial collapse to true, the folder's region start collapsed but after a few seconds their are expanded.
  2) It doesn't matter where the user start the editing all folded region will be expanded all the time.
  3) I found some NPE in the PartitionIdFoldingProvider#reportRegions method, but some unknown reason the "requestor" field is null. Unfortunately, I could not explain this behavior as far as I know the DelegatingFoldingStructure is the only class that calls to PartitionIdFoldingProvider's method I the execution flow seems to be OK (I could not see any new thread). I'll try to isolate and identify the specific issue here.

For 1) and 2) I remember this bugs were present in AbstractASTFoldingStructureProvider, but then all them were fixed. Could any one point me were to look for these issues?

Thanks in advance,
--
edgar

_______________________________________________ dltk-dev mailing list dltk-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dltk-dev

Back to the top