Re: [Dltk-dev] Help

[Alex Panchenko <alex@xxxxxxxxx>]

Hi Zhao,

30Kb patch always looks suspicious :-) I've wanted to discuss it.

Is all of the patch targeted to speed up that ElementHandler.handle() ? I ask as there are *Hierarchy* classed affected too. And ILazyMember idea doesn't look right for me.

Is there any difference between workspace & external source modules?

How is it possible to reproduce the performance bottleneck? (I prefer something e.g. "generate N files looking like .... and try to complete ...").

Regards,
Alex

----- Original Message -----
From: "赵忠伟" <zhaozhongwei@xxxxxxxxxxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Sent: Sunday, April 25, 2010 11:34:17 AM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] Help

Hi guys

There is a very annoying performance issue of PDT content assist,and I open a bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=309422

After I debug ,I found that it is very time consuming in ElementHandler.handle to get ISourceModule(it seems that there are file operations to get ISourceModule),so I create a patch that get ISourceModule when needed for content assist,and then the performance is improved much more,I am not sure if there are better ways,so I am glad to hear your voices!Because when there are 5000 proposals,it will cost more than 5 sec(longer than the default timeout)!So we have to fix this issue.


Thanks very much!!!

--

Thanks!

Best Regards!

Zhao

_______________________________________________ dltk-dev mailing list dltk-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/dltk-dev