Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [Dltk-dev] Re: New indexing infra

+1 for including it in the feature, it will encourage adopters to use this indexer rather the “default” one.

 

Roy

From: dltk-dev-bounces@xxxxxxxxxxx [mailto:dltk-dev-bounces@xxxxxxxxxxx] On Behalf Of Michael Spector
Sent: Wednesday, July 29, 2009 5:41 PM
To: DLTK Developer Discussions
Subject: [Dltk-dev] Re: New indexing infra

 

Hi All,

 

The changes are finally merged to HEAD. The question now is whether we want to create another feature for H2-based index or include it into org.eclipse.dltk.core feature?

 

Thanks!

 

On Tue, Jul 28, 2009 at 3:13 PM, Michael Spector <spektom@xxxxxxxxx> wrote:

Hi,

 

I've done a small refactoring so far:

 

DLTK:

----------

external/plugins/org.h2.core (HEAD) ----- H2 database

core/plugins/org.eclipse.dltk.core (INDEX2)  -----New indexer infrastructure + usage of new indexer in hierarchy resolver, etc..

core/plugins/org.eclipse.dltk.ui (INDEX2) ----- Usage of new indexer in Search UI, Open Type, Open Method, etc...

core/plugins/org.eclipse.dltk.core.index.sql (HEAD) ----- Basic SQL-based indexer implementation

core/plugins/org.eclipse.dltk.core.index.sql.h2 (HEAD) ----- H2-specific indexer implementation

 

PDT (just for usage example):

-------

plugins/org.eclipse.php.core (INDEX2)

plugins/org.eclipse.php.ui (INDEX2)

 

 

PS: Desperately waiting for the review of changes in org.eclipse.dltk.core before merging them with HEAD :)

 

Best regards,

Michael

 

On Sun, Jul 26, 2009 at 5:35 PM, Michael Spector <spektom@xxxxxxxxx> wrote:

Hi guys,

 

I would like to merge these changes made in INDEX2 branch into HEAD. New indexing infrastructure should not affect other plug-ins - it works only if enabled explicitly. Please review the changes and report any issues that you see.

 

Affected plug-ins (INDEX2 branch):

 

DLTK:
------
org.h2.core
org.eclipse.dltk.core


org.eclipse.dltk.core.h2

PDT:
-----
org.eclipse.php.core


org.eclipse.php.core.h2

org.eclipse.php.ui

 

Thanks in advance,

Michael

 

On Thu, Jul 16, 2009 at 4:54 PM, Michael Spector <spektom@xxxxxxxxx> wrote:

Hi All,

 

I've just committed new indexing infrastructure into special 'INDEX2' branch. This index is going to solve one of the huge performance bottle-necks in DLTK: JDT style index performing a lot of IO operations. Affected plug-ins are:

 

org.eclipse.dltk.core - Abstract indexing infrastructure under 'index2' source folder.

org.eclipse.dltk.core.h2 - Index implementation using H2 database.

org.h2.core - H2 Database (licensed under EPL)

 

To see live example that uses this index please refere to PDT plug-in: org.eclipse.php.core.h2 (HEAD). I must admit, that performance has been improved dramatically with new index without changing the flow - just replacing old SearchEngine call with new one.

 

The next step will be adapting existing usages of JDT-style SearchEngine in DLTK Core/UI to this index (may be through some extension point).

 

Please look at these plug-ins, and lets discuss it!

 

 

Thanks a lot for your time,

Michael

 

 

 

 

Back to the top