Hi Gabriel,
I have extracted "void createContentControls(Composite composite, final int nColumns)" method.
It looks like the most general approach. You can override it, call super and create additional controls on the same composite.
Regards,
Alex
----- Original Message -----
From: "Gabriel Petrovay" <gabipetrovay@xxxxxxxxx>
To: "dltk-dev" <dltk-dev@xxxxxxxxxxx>
Sent: Tuesday, May 12, 2009 4:35:44 AM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] Feature request: NewSourceModulePage.createCustomControls()
Hi Alex,
My problem with all the extension s the following (maybe you have a suggestion for this or a better practice):
I am extending your code by overriding methods in my own classes. On one hand, I have often met the case that the DLTK has TODO's in the code. On the other, people report bugs and ask for feature requests. As a consequence you change the code of the base classes. How can I automatically update my overridden methods based on your updates? I also want to bbeneffit of your corrections.
Having a solution like the feature request of this thread is the way I understand solving this problem. If you have a better solutoin, please let me know. If not, could you add such a method since:
1. "there are good chances this class would be further extended" and
2. the code is independent of the clients already implementing the base class (and it's perfectly backward compatible)
?
Also the amount of change is 3 lines of code for you (I could send you a patch :) ) while the solution you proposed means overriding the createControls method. which is many time more code and suffers from the limitation I described above.
Please suggest a solution or let me send you a patch.
Thanks!
Rgards,
Gabriel
PS: :) I always wear this smile when I write e-mails to you guys.
----- Original Message -----
Hi Gabriel,
I am not sure if additional method is required since
a) you might want add additional controls in different places in-between controls provided by the base page class
b) there are good chances this class would be further extended.
Regards,
Alex
----- Original Message -----
From: "Gabriel Petrovay" <
gabriel.petrovay@xxxxxxxxxx>
To: "dltk-dev" <
dltk-dev@xxxxxxxxxxx>
Sent: Saturday, May 9, 2009 2:07:39 AM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] Feature request: NewSourceModulePage.
createCustomControls()
Hi,
Could you provide such a method for the wizard pages (in this case
NewSourceModulePage) such that we can put some custom controls on the
pages? Of course everything is public and protected and can be
overridden, but I think a general solution is nicer.
Thanks!
Gabriel
--
MSc Gabriel Petrovay
Mobile: +41(0)787978034
www.28msec.com
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev
