RE: [Dltk-dev] External files in PDT

["Vadim Punski" <vadim.p@xxxxxxxx>]

Hi,
There are two changes performed due to next issues opened:

Opened external file - model not updated
https://bugs.eclipse.org/bugs/show_bug.cgi?id=266668
change in
org.eclipse.dltk.internal.ui.editor.DocumentAdapter.initialize()
performed to add support for external file opened,
when no fFile(IFile) exists, but fPath(IPath) is known.



No validation for opened external files in PDT
https://bugs.eclipse.org/bugs/show_bug.cgi?id=267008

SourceModuleAnnotationModel changed to public inner class, in order to
have a possibility to extend it and create custom annotation model.
AbstractSourceModule.getAccumulatingProblemReporter, ModelManager.
getAccumulatingProblemReporter - detection of ExternalScriptProject
improved.

And the third one is contributed:

No fake source created for NonExistingFileEditorInput
https://bugs.eclipse.org/bugs/show_bug.cgi?id=268080

In the flow similar to create new "Untitled Text File", but actually
"Untitled Script File", NonExistingPHPFileEditorInput class is used.
There is no support for such subclass of IEditorInput in
SourceModuleDocumentProvider.createFakeSourceModule().

All these changes add support for not-in-project opened files, together
with validation, code assist, outline, etc...


Regards,
	Vadim



-----Original Message-----
From: Roy Ganor 
Sent: Monday, March 09, 2009 11:30 AM
To: DLTK Developer Discussions
Cc: Vadim Punski
Subject: RE: [Dltk-dev] External files in PDT

Hi Alex, thank you for this build,
You're completely right - we will make a summary notes for changes we
made. 

- Roy


-----Original Message-----
From: dltk-dev-bounces@xxxxxxxxxxx [mailto:dltk-dev-bounces@xxxxxxxxxxx]
On Behalf Of Alex Panchenko
Sent: Monday, March 09, 2009 10:11 AM
To: DLTK Developer Discussions
Subject: Re: [Dltk-dev] External files in PDT

Hi Roy,

The DLTK integration build is ready.

It is inconsistent for me if DLTK bugs are resolved but I can't test the
described functionality :)
Also, I am not sure if getPerWorkingCopyInfo() should modify
problemRequestor, since it doesn't follow original design.

I think it should be more clear how each change in the DLTK-core is
supposed to be used by other languages, etc. It guarantees that the next
changes for X language will not break the code added for the Y language
:)

Regards,
Alex

----- Original Message -----
From: "Roy Ganor" <roy@xxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Cc: "Alexey Panchenko" <alex@xxxxxxxxx>
Sent: Sunday, March 8, 2009 7:10:27 PM GMT +06:00 Almaty, Novosibirsk
Subject: RE: [Dltk-dev] External files in PDT

Hi,
I hope that it will work soon on ruby and all other implementations ;) 

Since this change exposes a new API (altering modifier for the
SourceModuleAnnotationModel from protected to public) we ask for a DLTK
integration build that we can use for our builds and share with our
users.

Thanks for your time,
- Roy

-----Original Message-----
From: dltk-dev-bounces@xxxxxxxxxxx [mailto:dltk-dev-bounces@xxxxxxxxxxx]
On Behalf Of Alex Panchenko
Sent: Sunday, March 08, 2009 1:45 PM
To: DLTK Developer Discussions
Subject: [Dltk-dev] External files in PDT

Hello,

As I can see the following patches
https://bugs.eclipse.org/bugs/show_bug.cgi?id=266668
https://bugs.eclipse.org/bugs/show_bug.cgi?id=267008
were recently committed.

It's great that it works for PDT. Now, I would like to know what exactly
works and if additional changes are required to make it work for other
languages too.

At the moment if I open external ruby file (using menu - File - Open
File...) I don't see problem annotations in the editor and outline is
not updated on changes.


Alex
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev