[Dltk-dev] Re: encoding problems in the dbgp protocol (in/output streams

[Johan Compagner <jcompagner@xxxxxxxxx>]

also i see for example this:

        out.print(encodeString.length());
        out.write(0);
        out.print(encodeString);
        out.write(0);
        out.flush();

what does that length() mean? lenght in bytes?
Because then length() is not correct

On Wed, Mar 11, 2009 at 13:59, Johan Compagner <jcompagner@xxxxxxxxx> wrote:

Hi,

a customer of us does have problems with UTF8 chars when using the debugger
for example he has a utf8 char in the function name.

Then the problem is that i get an exception that there is illegal utf in the stream

we now do this:

eclipse side:
        receiver = new DbgpPacketReceiver(new BufferedInputStream(socket
                .getInputStream()));


db engine side:
         out = new PrintStream(socket.getOutputStream());


So that completely relies on system encoding.
If you would debug on system X and you have eclipse running on system Y this could be a problem.

Wouldnt it be better to use UTF-8 all the way?

something like this:

eclipse side:
       receiver = new DbgpPacketReceiver(new BufferedReader(new InputStreamReader(socket.getInputStream(),"UTF8")));


db engine side:
         out = new PrintStream(new BufferedWriter(new OutputStreamWriter(socket.getOutputStream(),"UTF8")));



problem is that we then have a reader instead of input stream, and quite a lot of code that works with inputstreams and bytes should then be changed
to use reader/chars