[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [Dltk-dev] Opening file in editor from within project that has no nature
|
Hi all,
Shelby, I have rolled back your changes in the
SourceModuleDocumentProvider.createFileInfo(Object) method to fix
Outline for files opened from RSE or in a project without DLTK natures.
Now the relevant part (near line 1256) looks like
if (ScriptModelUtil.isPrimary(original))
original.becomeWorkingCopy(requestor, getProgressMonitor());
Outline has a check if the source module exists. Source module outside
of a project with DLTK nature does not exist until we make it a working
copy. This is how it works in JDT.
Please check if the changes are OK for you. If you think the .exists()
check is necessary lets discuss other ways to handle it.
Michael, the change above fixes Outline. There is no need to remove
nature check from getPerProjectInfoCheckExistence() method. JDT checks
the project nature too.
Regards,
Alex
Michael Spector wrote:
Hi All,
I've trying to fix a bug (252369) saying that opening a PHP file from
RSE is not presented in Outline, and a lot of exceptions are thrown
into log file.
This is due to many restrictions in DLTK like in
ModelManager.getPerProjectInfoCheckExistence() (disabling check in
this method fixes Outline view, BTW).
I wonder what is the policy? I don't think project must have a nature
for simple editor/outline actions to work, and JDT can be a good
example of that.
But what, on your opinion, can be a side-effect of disabling these checks?
Thanks!
