[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [Dltk-dev] why do breakpoints have the full system path as the location?
|
Hi Johan,
It looks like we can use workspace-local path for the workspace
resources. Full path is required only for the external modules.
I have committed the change to create new breakpoints with
workspace-local path. Also I have added some checks so that double
clicking old breakpoint in the editor will find the previous one and
delete it and do not create the new one.
As far as I can test it - everything works correctly.
Regards,
Alex
Johan Compagner wrote:
the dltk (or at least javascript) breakpoints are not really
distributable because there is one property that has the complete
system path in it
I got a workspace from a co worker and i notice that i had breakpoints
but toggle it didnt work (i got another one)
when i investigated this i did see that there is a location property
of the marker that is a full system path
for example if i export breakpoints (eclipse feature) then i get this:
<breakpoint enabled="true" persistant="true" registered="true">
<resource path="/main/globals.js" type="1"/>
<marker charStart="338" lineNumber="15"
type="org.eclipse.dltk.debug.scriptLineBreakpointMarker">
<attrib name="message" value="Javascript: globals.js: [line: 15], 0
hits"/>
<attrib name="org.eclipse.debug.core.id
<http://org.eclipse.debug.core.id>"
value="org.eclipse.dltk.debug.javascriptModel"/>
<attrib name="location"
value="C:/servoy4/workspace/infogroen/main/globals.js"/>
<attrib name="charStart" value="338"/>
<attrib name="charEnd" value="350"/>
<attrib name="org.eclipse.dltk.debug.id
<http://org.eclipse.dltk.debug.id>" value="p5"/>
<attrib name="org.eclipse.dltk.debug.hit_count" value="0"/>
<attrib name="org.eclipse.debug.core.enabled" value="true"/>
</marker>
that location attribute seems wrong to me
i would say location should just be the resource path
Is that path also used for sending to the debugger engine? I guess we
should make it a full path then instead of keeping the full path like
we do now
johan
------------------------------------------------------------------------
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev
