Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [Dltk-dev] project specific task tags

alex -

  i checked this out tonight and it's not working. well, it is, and it isn't. :)

  it looks like the chained preference store that is passed to the ScriptSourceViewerConfiguration isn't looking at the project specific preferences for the same reason i couldn't get the project via the IEditorInput, it hasn't been wired up to the editor yet.

  if i set a breakpoint in the initializeScanenrs() method, it gets hit once when the editor is opened (called via initializeEditor) and the preference store passed to the source viewer does not contain the project specific properties, and again when the 'install' method is called when semantic hightlghting is setup, and this time the preference store does have the project specific values, b/c the editor resource has been wired up and the associated project can be obtained.

  it seems that there needs to be some kind of delayed initialization of the scanners until after the editor resource has been wired up. or maybe something else... :)

On Mon, Oct 6, 2008 at 6:56 AM, Alex Panchenko <alex@xxxxxxxxx> wrote:
Hi Jae,

The ChainedPreferenceStore created in
org.eclipse.dltk.internal.ui.editor.ScriptEditor.createCombinedPreferenceStore(IEditorInput)
should be able to read project specific preferences now.

I have added the method org.eclipse.dltk.core.IDLTKLanguageToolkit.getPreferenceQualifier() and use it to construct additional PreferenceStore instances.

It is great you are implementing project-specific task tags!

Regards,
Alex

Jae Gangemi wrote:
hello all -

 i'd like to see support for project specific task tags added. i've already taken care of all of the preference/property page work, but now i've run into a problem configuring the script scanner with the proper task tags.

 i was attempting to use the ITextEditor object that is passed to the ScriptSourceViewerConfiguration to obtain the IScriptProject for the editor object, but the problem is that when the ScriptSourceViewerConfiguration object is created, the underlying resource has not been wired up to the editor yet, and calling getEditorInput() against the ITextEditor object always yeilds null, so the PreferencesLookupDelegate object i am trying to create always gets passed null, and the ProjectScope object never gets created, and project level properties are never searched.

 i tried looking at what the jdt is doing, but i'm unsure of how their comment scanner is able to find the project specific settings since i don't see anything in their implementation using the IPreferencesService, which is what the IPreferenceLookupDelegate implemenation uses to look through the various preference scopes.

--
-jae
------------------------------------------------------------------------

_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev
 
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev



--
-jae

Back to the top