Re: [Dltk-dev] ToggleCommentAction usage

[Alex Panchenko <alex@xxxxxxxxx>]

Here we have incompatibility between 1.0/0.95:

In 1.0 it is created in the ScriptEditor

action = new ToggleCommentAction(DLTKEditorMessages.getBundleForConstructedKeys(), "ToggleComment.", this); //$NON-NLS-1$
action.setActionDefinitionId(IScriptEditorActionDefinitionIds.TOGGLE_COMMENT);
setAction(DLTKActionConstants.TOGGLE_COMMENT, action);
markAsStateDependentAction(DLTKActionConstants.TOGGLE_COMMENT, true);

in 0.95 it was created by language specific editors, e.g. RubyEditor:

action = new ToggleCommentAction(DLTKEditorMessages.getBundleForConstructedKeys(), "ToggleComment.", this); //$NON-NLS-1$
action.setActionDefinitionId(IScriptEditorActionDefinitionIds.TOGGLE_COMMENT);
setAction("ToggleComment", action); //$NON-NLS-1$
markAsStateDependentAction("ToggleComment", true); //$NON-NLS-1$

I would recommend you use 1.0 milestone builds.

Alex

----- Original Message -----
From: "Edgar Espina" <espina.edgar@xxxxxxxxx>
To: "DLTK Developer Discussions" <dltk-dev@xxxxxxxxxxx>
Sent: Friday, September 26, 2008 12:46:29 AM GMT +06:00 Almaty, Novosibirsk
Subject: Re: [Dltk-dev] ToggleCommentAction usage



Hi Alex! 

Where is created the ToggleCommentAction? 

The line 1068 on ScriptEditor always return null 
>> Line 1068: action = getAction("ToggleComment"); //$NON-NLS-1$ 

The method createActions doesn't create it. DLTK-0.95 

Thanks! 



On Thu, Sep 25, 2008 at 1:24 PM, Alex Panchenko < alex@xxxxxxxxx > wrote: 


Hi Edgar, 

ToggleCommentAction is already created in ScriptEditor, the comment sequence is specified by getCommentPrefix() method of the ScriptSourceViewerConfiguration class. If your comment sequence is different this method should be overridden. 

Regards, 
Alex 




----- Original Message ----- 
From: "Edgar Espina" < espina.edgar@xxxxxxxxx > 
To: "DLTK Developer Discussions" < dltk-dev@xxxxxxxxxxx > 
Sent: Thursday, September 25, 2008 10:50:44 PM GMT +06:00 Almaty, Novosibirsk 
Subject: [Dltk-dev] ToggleCommentAction usage 



Hi all, 
How can I add comment action to my editor? 
Can I use org.eclipse.dltk.internal.ui.editor.ToggleCommentAction? 

thanks! 
-- 
edgar 

_______________________________________________ 
dltk-dev mailing list 
dltk-dev@xxxxxxxxxxx 
https://dev.eclipse.org/mailman/listinfo/dltk-dev 
_______________________________________________ 
dltk-dev mailing list 
dltk-dev@xxxxxxxxxxx 
https://dev.eclipse.org/mailman/listinfo/dltk-dev 



-- 
edgar 

_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev