Re: [Dltk-dev] DLTK API: to break or not to break

[Andrei Sobolev <andrei.sobolev@xxxxxxxxx>]

Hi Michael,

I've updated AbstractSourceModule class and getMethods() is now in place.

Thanks.
> Hi,
>
> I think now there's a breakage in another place:
> SourceModule.getMethods() was removed, but this method has nothing to 
> do with the recent commit, which has broke the API.
>
>
> On Mon, Jul 7, 2008 at 12:21 PM, Andrey Platov <andrey@xxxxxxxxx 
> <mailto:andrey@xxxxxxxxx>> wrote:
>
>     Hi folks,
>
>     Recent commit to Zend breaks API resulting in JavaScript component
>     do not compile. So I'd like to ask all the committers to be more
>     thoughtful on API changes.
>
>     When you can do anything without breaking API, please do not break
>     API:
>
>     Last commit introduce getMethods() method to ISourceModule class.
>     Obviously ISourceModule is an interface which used heavily among
>     DLTK components and Core. DLTK feeling good without this method,
>     so it's very likely just committed functionality will live well
>     without this breaking API change. getMethods() is used from single
>     place of new functionality and can be easily inlined instead.
>     [Andrei just removed getMethods() and inlined that functionality]
>
>     I'm not contrary to changing API, but uncontrolled API grow result
>     in a number of problems (like JavaScript won't build today).
>
>     So please if you *really need* to break API, please post that
>     changes on the list to understand impact on components and get
>     everyone prepared to follow that changes.
>
>     Kind Regards,
>     Andrey
>
>
>     _______________________________________________
>     dltk-dev mailing list
>     dltk-dev@xxxxxxxxxxx <mailto:dltk-dev@xxxxxxxxxxx>
>     https://dev.eclipse.org/mailman/listinfo/dltk-dev
>
>
>
>
> --
> Michael
> ------------------------------------------------------------------------
>
> _______________________________________________
> dltk-dev mailing list
> dltk-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/dltk-dev
>