Eclipse is trying to apply a consistent reserved word approach to the
package naming. Reserved words are internal, tests, and examples.
These reserved words all occur in the same general location in a
package name, after the subproject name or component name, depending on
the situation. The following projects are using this convention, or
something very close to it: Eclipse Core, JDT Core, BIRT, TPTP, and
Hyades. The WTP
convention prefers that the reserved word be pushed to the right of
the component in every case, but still enforces the concept of the
reserved word preceding the specific package function -"The preferred
usage is to put the reserved names in the fifth position, leaving the
fourth position for the component name."
In either case, "tests" should end up after the dali segment, as with
the platform standard it would be "org.eclipse.dali.tests.core",
and in the WTP it would likely be "org.eclipse.jst.dali.tests.core."
So for now "org.eclipse.dali.tests.core"
is the model we should follow.
I agree that we should break the tests out into there own "tests"
folder.
Neil
Paul Fullbright wrote:
I guess since no one follows it, I wouldn't consider it 'bucking'.
This makes more sense *to me*, but I'm not opposed in principal to
anything else.
Karen Moore wrote:
My only concern with this is that we are bucking the eclipse naming
conventions found here http://dev.eclipse.org/naming.html?
It is my understanding that following these conventions our test plugins
would be:
org.eclipse.dali.tests
org.eclipse.dali.tests.core
org.eclipse.dali.tests.ui
...
instead of your suggestion of:
org.eclipse.dali.tests
org.eclipse.dali.core.tests
org.eclipse.dali.ui.tests
What is the reasoning behind not using the naming convention other than that
no one else seems to follow any convention either? These naming conventions
also apply to internal packages which other plugins seem to all follow.
Karen
-----Original Message-----
From: dali-dev-bounces@xxxxxxxxxxx [mailto:dali-dev-bounces@xxxxxxxxxxx] On
Behalf Of Paul Fullbright
Sent: Monday, January 23, 2006 4:02 PM
To: General Dali EJB ORM developer discussion.
Subject: Re: [dali-dev] Test plugins
Well, that is *one* thing that is pretty conventional. "tests" is used
almost exclusively across eclipse, I believe because the package that
the plugin represents doesn't contain a "test" component, but rather
multiple tests.
Shaun Smith wrote:
I haven't looked through the cvs repository but in my experience test
packages are just singular ".test" just like ".utility" is singular. Come
to think of it, most packages are singular, ignoring WTP's "tests".
Shaun
-----Original Message-----
From: dali-dev-bounces@xxxxxxxxxxx
[mailto:dali-dev-bounces@xxxxxxxxxxx]On Behalf Of Paul Fullbright
Sent: Monday, January 23, 2006 11:36 AM
To: General Dali EJB ORM developer discussion.
Subject: [dali-dev] Test plugins
All,
I've scoured the cvs servers, and I can find no real "convention" on
test plugin naming, therefore, I suggest that we follow the following
pattern that I *have* seen in several cases.
Plugins:
org.eclipse.dali (for future 'skeleton' plugin information)
org.eclipse.dali.core
org.eclipse.dali.db
org.eclipse.dali.edit
org.eclipse.dali.ui
org.eclipse.dali.utility
Tests:
org.eclipse.dali.tests (can run all below tests from one suite)
org.eclipse.dali.core.tests
org.eclipse.dali.db.tests (if needed)
org.eclipse.dali.edit.tests (probably not needed)
org.eclipse.dali.ui.tests
org.eclipse.dali.utility.tests (can pull existing utility tests into
here)
In addition, most WTP components keep their tests in a "tests" folder
parallel to their "plugins" folder. We have the plugins folder, but no
tests folder. I think that should be created and tests moved there.
Any thoughts or discussion on this?
- Paul
_______________________________________________
dali-dev mailing list
dali-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dali-dev
_______________________________________________
dali-dev mailing list
dali-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dali-dev
_______________________________________________
dali-dev mailing list
dali-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dali-dev
_______________________________________________
dali-dev mailing list
dali-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dali-dev
_______________________________________________
dali-dev mailing list
dali-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dali-dev
|
