Re: [cross-project-issues-dev] Eclipse platform contribution with Jetty

["Sravan K Lakkimsetti" <sravankumarl@xxxxxxxxxx>]

Hi,

 

Can org.slf4j.api be added to target platform in https://git.eclipse.org/c/tracecompass/org.eclipse.tracecompass.git/tree/releng/org.eclipse.tracecompass.target/tracecompass-e4.20.target (we get it from Orbit see https://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.prereqs.sdk/eclipse-sdk-prereqs.target#n73)  and/or can this be added to https://git.eclipse.org/c/tracecompass/org.eclipse.tracecompass.git/tree/rcp/org.eclipse.tracecompass.rcp.product/tracing.product in the plugins section.

 

We mirror org.slf4j.api from orbit. My preference here is to fetch from orbit.

 

I would prefer not rebuild platform again.

 

Thanks

Sravan

 

From: Patrick Tasse <patrick.tasse@xxxxxxxxx>
Sent: 09 June 2021 20:59
To: Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cross-project-issues-dev] Eclipse platform contribution with Jetty 10.0.4 upgrade

 

Hi,

 

We depend on platform which includes help feature.

The help feature used to depend on jetty.http 10.0.2 which depends on org.slf4j 2.0, with Bundle-SymbolicName: slf4j.api

The help feature now depends on jetty.http 10.0.4 which depends on org.slf4j 1.7, with Bundle-SymbolicName: org.slf4j.api

 

The help feature.xml used to include feature slf4j.api, this has just been removed.

 

So I believe the help feature.xml must now include feature org.slf4j.api instead?

 

Thanks,

Patrick

 

 

On Wed, Jun 9, 2021 at 11:05 AM Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx> wrote:

Based on https://www.eclipse.org/lists/cross-project-issues-dev/msg18389.html there are some places you will need slf4j version 2. In all other places we should be good with slf4j 1.7.30.

 

Thanks

Sravan

 

From: Nitin Dahyabhai <thatnitind@xxxxxxxxx>
Sent: 09 June 2021 19:36
To: Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [cross-project-issues-dev] Eclipse platform contribution with Jetty 10.0.4 upgrade

 

WTP doesn't contribute it either, just the ones that were needed and not provided in the Platform build. What I find curious is that both https://download.eclipse.org/eclipse/jetty/10.0.4/plugins/ and https://download.eclipse.org/webtools/jetty/10.0.4/repository/plugins/ ended up with the 2.0.0 jar in their output. What I find troubling is that we use jetty-plus to resolve some OSGI Require/Provide-Capability configuration once installed, so I expect our build will compile cleanly but the related functionality will fail to load properly. :(

 

On Wed, Jun 9, 2021 at 9:45 AM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

:-( But the Platform contribution does not have slf4j.api_2.0.0.alpha1, is that because Platform doesn't use  jetty-jndi and jetty-plus but WTP does?

 

Thanks

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

 

 

On Wed, 9 Jun 2021 at 09:40, Nitin Dahyabhai <thatnitind@xxxxxxxxx> wrote:

It looks like jetty-jndi and jetty-plus did not have their SLF4J ranges lowered under 2.0, so the Jetty sites from Platform and WTP both still contain slf4j.api_2.0.0.alpha1.

 

On Wed, Jun 9, 2021 at 9:20 AM Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx> wrote:

Hi,

 

I contributed eclipse platform with Jetty 10.0.4 and with slf4j 1.7.30. Please let me know if there are any problems.

 

Thanks

Sravan

 

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev

 

--

Regards,

Nitin Dahyabhai

Eclipse WTP PMC

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev

 

--

Regards,

Nitin Dahyabhai

Eclipse WTP PMC

 

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev