Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Equinox fix for Luna SR1 now available as a feature patch in "4.4" repository.


> As an aside: This issue does serve as a a good reminder of the
> second part of my favorite mantra: test early, test often! :)  ...
> since this bug this was introduced in RC2 (to fix another
> regression), if I recall.  
>

Note that this particular issue got introduced on August 7th [1] before RC1 of SR1.  It was to fix a regression in Luna from the Kepler release.  Obviously the fix was bad, but it was there before the first release candidate for testing.  

In this particular case the blame for the bad fix is a lack of review on the original fix.  Not something I personally plan to repeat for maintenance releases again.  I've been developing Equinox/Eclipse stuff for so long that arrogance and [excuse] lack of active involvement by other committers led me to releasing the fix in SR1 with the thoughts that any issues will get worked out before the final build.  With all that said, even with code reviews, nothing beats a good round of testing from the community before the final release candidate.

My 2 cents, I think the release train absolutely should have a configured repo that points to a designated spot for releasing fixes.  It is inevitable that we will hit the occasional bad bug that needs an immediate fix available to the broader user community.

Sorry for the inconvenience this particular issue has caused.

Tom

[1] http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=6518be6daad51538b7124f49a889a4a762b63a07



Back to the top