Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] Regarding the new shared license feature

Hi Kim,

I was poking around your license feature and noticed that build.properties refers to eclipse_update_120.jpg but there is no image in the feature. Should the image be in the feature, or are the properties wrong?

Greg

On Mar 2, 2011, at 3:50 PM, Kim Moir wrote:

You don't need to include your license feature in any other features. If you update your maps to include a reference to the location of your license feature, it should be fetched automatically by the features that refer to the license.   Do you actually ship your container feature or is it just used at build time?  If so, #3.  

What does your feature.xml look like for the license feature and an feature that references it? I tried to access your SVN repo, but was denied access.  From the log, It looks like it's having problems parsing a feature.xml.


Kim



From:        Daniel Pastore <kpqb38@xxxxxxxxxxxx>
To:        Cross project issues <cross-project-issues-dev@xxxxxxxxxxx>
Date:        03/02/2011 03:19 PM
Subject:        [cross-project-issues-dev] Regarding the new shared license feature
Sent by:        cross-project-issues-dev-bounces@xxxxxxxxxxx




Hi guys,

I am trying to implement the new shared license feature in the Sequoyah build, but I think I'm doing something wrong or I missed something. :(

I read Kim's post, and then I created a new feature org.eclipse.sequoyah.license.feature, which has 5 files: build.properties, epl-v10.html, feature.properties, feature.xml and license.html.
Also, I used David William's tool to change every other feature accordingly to the new model and double checked they were correct (I had to change the feature name).
Meanwhile, I updated the eclipse I use to build and now it is a 3.7M5 eclipse, that should include the shared license support.

Now here comes my problem: we use a container feature to build Sequoyah, using an ant build file. I tried 4 scenarios:
1) Include sequoyah.license.feature in the container feature and also use the license-feature property for the container;
2) Include sequoyah.license.feature in the container feature and not use the license-feature property for the container;
3) Do not include sequoyah.license.feature in the container feature and use the license-feature property for the container;
4) Do not include sequoyah.license.feature in the container feature and not use the license-feature property for the container;

For all of them, I received the same build failed status, with the following remarkable exception for every single feature:
     [java] publish.bin.parts:
     [java]     [mkdir] Created dir: /opt/public/tools/sequoyah/indigo/temp/eclipse.build/features/org.eclipse.sequoyah.device.feature/feature.temp.folder/features/org.eclipse.sequoyah.device.feature_2.0.0.N20110302-1139
     [java]      [copy] Copying 3 files to /opt/public/tools/sequoyah/indigo/temp/eclipse.build/features/org.eclipse.sequoyah.device.feature/feature.temp.folder/features/org.eclipse.sequoyah.device.feature_2.0.0.N20110302-1139
     [java] [eclipse.gatherFeature] Generating metadata for ..
     [java] [eclipse.gatherFeature] org.xml.sax.SAXParseException: Content is not allowed in prolog.
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:236)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:215)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:386)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:316)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1441)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDispatcher.dispatch(XMLDocumentScannerImpl.java:899)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:368)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:834)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:764)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:148)
     [java] [eclipse.gatherFeature] at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1242)
     [java] [eclipse.gatherFeature] at javax.xml.parsers.SAXParser.parse(SAXParser.java:375)
     [java] [eclipse.gatherFeature] at org.eclipse.equinox.internal.p2.publisher.eclipse.FeatureManifestParser.parse(FeatureManifestParser.java:98)
     [java] [eclipse.gatherFeature] at org.eclipse.equinox.internal.p2.publisher.eclipse.FeatureParser.parse(FeatureParser.java:52)
     [java] [eclipse.gatherFeature] at org.eclipse.pde.internal.build.publisher.GatherFeatureAction.getFeatures(GatherFeatureAction.java:44)
     [java] [eclipse.gatherFeature] at org.eclipse.equinox.p2.publisher.eclipse.FeaturesAction.perform(FeaturesAction.java:600)
     [java] [eclipse.gatherFeature] at org.eclipse.equinox.p2.publisher.Publisher$ArtifactProcess.run(Publisher.java:207)
     [java] [eclipse.gatherFeature] at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.executeBatch(SimpleArtifactRepository.java:1062)
     [java] [eclipse.gatherFeature] at org.eclipse.equinox.p2.publisher.Publisher.publish(Publisher.java:231)

I have cut the log here, because it seems to me that somehow the p2.publisher is not understanding the new model (at org.eclipse.equinox.internal.p2.publisher.eclipse.FeatureManifestParser.parse(FeatureManifestParser.java:98)).

Any hints and thoughts are welcome, please!
--
Thanks,

Daniel Pastore

Sequoyah Team
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev


Back to the top