Re: [cross-project-issues-dev] Platform filters and the aggregator

[Stephan Herrmann <stephan@xxxxxxxxxxxxxxx>]

Hi Thomas,

> Would it be possible for you to simply write one single declaration like 
> this:
> 
>       <plugin
>           id="org.eclipse.objectteams.otequinox.sunjvm"
>           os="linux,solaris,win32"
>           ... />
> 
> ?

I could try that, once we have the next successful build (wouldn't help much
to further break a broken build, right?). 
Yet according to Jacek's reply my original version should be correct.
 
> I'm not sure what the problem really is since the aggregator doesn't 
> care much about your feature.xml. It will only consult the p2 meta-data.

Here's the relevant metadata (from an old build):

    <unit id='org.eclipse.objectteams.otequinox.feature.group' version='0.7.0.201007050931' singleton='false'>
      <update id='org.eclipse.objectteams.otequinox.feature.group' range='[0.0.0,0.7.0.201007050931)' severity='0'/>
      <properties size=..>...
      </properties>
      <provides size='2'>
        <provided namespace='org.eclipse.equinox.p2.iu' name='org.eclipse.objectteams.otequinox.feature.group' version='0.7.0.201007050931'/>
        <provided namespace='org.eclipse.equinox.p2.localization' name='df_LT' version='1.0.0'/>
      </provides>
      <requires size='10'>
        <required namespace='org.eclipse.equinox.p2.iu' name='org.eclipse.objectteams.otequinox.sunjvm' range='[0.7.0.201006211729,0.7.0.201006211729]'>
          <filter>
            (osgi.os=linux)
          </filter>
        </required>
        <required namespace='org.eclipse.equinox.p2.iu' name='org.eclipse.objectteams.otequinox.sunjvm' range='[0.7.0.201006211729,0.7.0.201006211729]'>
          <filter>
            (osgi.os=solaris)
          </filter>
        </required>
        <required namespace='org.eclipse.equinox.p2.iu' name='org.eclipse.objectteams.otequinox.sunjvm' range='[0.7.0.201006211729,0.7.0.201006211729]'>
          <filter>
            (osgi.os=win32)
          </filter>
        </required>
        ...
    </unit>

Anything that the aggregator doesn't like?
 
> PS.
> What's the relevance of the fragment="true" in a feature plugin 
> declaration? I know it can be entered, but does it have any purpose?

I can only tell that this is what PDE's editor generated and that it 
seems to make sense to me :)
Metadata generation doesn't seem to use this value, though (see above).

Anybody else using platform filters for fragments?
Any tweaks you had to apply to make the aggregator happy?

Stephan