| [cosmos-dev] Request approval for bug 253780 |
I am requesting approval for Bug 253780 - Problems with Firefox browser .
1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of COSMOS / consuming products be affected if the defect is not fixed?
Most of the data visualization widgets can not be rendered. As a result a loss of major functionality in the COSMOS UI console.
2. Is there a work-around? If so, why do you believe the work-around is insufficient?
There is no work-around.
3. Is this a regression or API breakage? Explain.
This problem is a regression problem. It seems the added copyright comments
added to the html file caused this problem.
For example, the following comment structure caused the problem:
<!--
/*******************************************************************************
* Copyright (c) 2008 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* IBM Corporation - initial version
* CA - edits
*******************************************************************************/
-->
<div>
</div>
The comments should be encased inside the div element as follows:
<div>
<!--
/*******************************************************************************
* Copyright (c) 2008 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* IBM Corporation - initial version
* CA - edits
*******************************************************************************/
-->
</div>
4. Does this require new API?
No new public APIs are required.
5. Who performed the code review?
No one. The patch attached can be reviewed. https://bugs.eclipse.org/bugs/attachment.cgi?id=117008
6. Is there a test case attached to the bugzilla record?
This test is covered by the E2E test.
7. What is the risk associated with this fix?
Low. The fix is moving the html comments to another section in the html file. Specifically, the HTML comments should be moved from the beginning of the html widget file and encased in the parent div element.
8. Is this fix related to any standards that COSMOS adheres to? If so, who has validated that the fix continues to adhere to the standard?
No
Thanks,
Sheldon