Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[cosmos-dev] Fw: [eclipse.org-committers] Committes: How to count lines of code in a contribution


Hi Committers,

A reminder that when you are checking a contribution that has been sent to you via bugzilla that you are required to check the number of lines that it contains. If it exceeds 200 lines of code then we need to request permission from Eclipse Legal before committing the code to CVS.

A health question to all Subproject Leads: how many code contributions have your committers checked into CVS and of them how many exceed 200 lines of code? Tania, when you book the pre-release-review meeting, can you add this item to the agenda, please? We'll need this information in order to create our Project IP Log.

Thanks,
Ruth.


Ruth Lee
IBM Toronto Lab
ruthdaly@xxxxxxxxxx
T/L 313-4453

----- Forwarded by Ruth Lee/Toronto/IBM on 03/27/2008 01:25 PM -----
"Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>
Sent by: eclipse.org-committers-bounces@xxxxxxxxxxx

03/27/2008 12:47 PM

To
"Target Management developer discussions" <dsdp-tm-dev@xxxxxxxxxxx>
cc
eclipse.org-committers@xxxxxxxxxxx, cdt-dev@xxxxxxxxxxx, dsdp-dd-dev@xxxxxxxxxxx
Subject
[eclipse.org-committers] Committes: How to count lines of code in a        contribution





Dear Committers,
 
Here's a message due to a recent incident:
part of our due diligence when accepting a community contribution is filing the tm-log.csv IP log, which also asks for a lines of code number in the contribution.
 
How to count lines of code most easily, and correctly?
You might want to consider using my "lcp" script to count lines in a patch:
http://www.eclipse.org/dsdp/tm/development/committer_howto.php#sloccount

It counts the "+" added lines only and subtracts empty lines as well as lines that only have a comment.

You're right that removing lines also constitutes an act of creativity so even a patch that ONLY removes lines is valuable. But for the application in our tm-log.csv it's more important to count how much new copyrightable stuff comes
in through the patch. And that is comprised of the "+" lines only.

The script is still not perfect in the case where existing code is only moved to a different place (leading to lots of + along with the same number of - lines, which also constitutes creativity but not necessarily new copyrightable
stuff). But finding out such moves is beyond the scope of what we should do when counting lines.

Hope you find this useful,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
 
 _______________________________________________
eclipse.org-committers mailing list
eclipse.org-committers@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipse.org-committers

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact emo@xxxxxxxxxxx to request removal.

Back to the top