Re: [corona-dev] Problem with debug option in corona log service.

[Marcin Okraszewski <marcin.okraszewski@xxxxxxxxxxxxxxxx>]

After preety long discussion with Piotr we went into following conclusion:
1. log4.properties will contain definition of a default log level
2. logger for each plugin will have the default value set
3. in Eclipse tracing options we will have log level instead of debug
option; CoronaLogService.isDebug() will return true only if the log
level is set to DEBUG.
4. if a plugin has a log level in tracing options, it will override the
default value in log4.properties

Note, that in this way we are going to skip log4j tree level structure.
It seems for us that this the most reasonable way to join a per bundle
configuration in tracing with log level inheritance in log4j.

Marcin


Everitt, Glenn napisał(a):

> I still think you can have the logging service use the log4j filtering to accomplish turning on / off logging for each plugin.  I also think log4j developers have spent a lot of time optimizing the hierarchical logger approach.  But you mentioned you didn't like the coupling between log service and log4j.  For what it is worth...
>
> -----Original Message-----
> From: corona-dev-bounces@xxxxxxxxxxx [mailto:corona-dev-bounces@xxxxxxxxxxx] On Behalf Of Marcin Okraszewski
> Sent: Friday, January 05, 2007 11:45 AM
> To: Corona development
> Subject: Re: [corona-dev] Problem with debug option in corona log service.
>
> Sorry, something wrong with the image - one more again.
>
>
>
> Marcin Okraszewski napisał(a):
>
>  
>
> > This means that in fact the in fact Log4j is just a writter? No 
> > filtering at all?
> >
> > Recently when I was suggesting that writting to Eclipse log should be 
> > done directly from OSGi Log service, you said that Log4j should do it, 
> > because we want to use its filtering capabilities.
> >
> > Honestly I think current logging approach is fairly complicated. I 
> > attach a layer diagram of current state. The green boxes are things 
> > implemented by us.
> >
> > Marcin
> >
> > Everitt, Glenn napisał(a):
> >
> >    
> >
> > > It seems to me that we are building a logging service for Corona 
> > > Plugins and we have built it so that we could change the underlying 
> > > logging implementation. So...I don't think we should make the logging 
> > > service behave like the logging implementation. For plugins I think 
> > > you want to turn on/off logging for a individual plugins. It would be 
> > > nice if the service let you turn on logging for a group of plugins 
> > > based upon wild carding the plugin name. For example 
> > > org.eclipse.corona.* turns on logging for all plugins with name 
> > > prefix org.eclipse.corona. I think this means the logging service 
> > > does the filtering not log4j.
> > >
> > > clSetLevel org.eclipse.corona DEBUG -only turns on debug for 
> > > org.eclipse.corona plugin
> > >
> > > clSetLevel org.eclipse.corona.* DEBUG - turns on debugging for all 
> > > org.eclipse.corona plugins.
> > >
> > > Glenn Everitt
> > >
> > > The contents of this e-mail are intended for the named addressee 
> > > only. It contains information that may be confidential. Unless you 
> > > are the named addressee or an authorized designee, you may not copy 
> > > or use it, or disclose it to anyone else. If you received it in error 
> > > please notify us immediately and then destroy it.
> > >
> > > ------------------------------------------------------------------------
> > >
> > > _______________________________________________
> > > corona-dev mailing list
> > > corona-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/corona-dev
> > >
> > >
> > >      
> > The contents of this e-mail are intended for the named addressee only. 
> > It contains information that may be confidential. Unless you are the 
> > named addressee or an authorized designee, you may not copy or use it, 
> > or disclose it to anyone else. If you received it in error please 
> > notify us immediately and then destroy it.
> > ------------------------------------------------------------------------
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > corona-dev mailing list
> > corona-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/corona-dev
> >
> >
> >    
> The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it. 
> _______________________________________________
> corona-dev mailing list
> corona-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/corona-dev
>
>
>  

The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it.