Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[corona-dev] Opening adapters on PC open?

I think we a bug that may cause resources leak. When PC is opened in PCX, for each repository an adapter is created an method IRepositoryAdapter.open() is invoked. This is done in order to open imported projects in Eclipse IDE. But I'm affraid that semantic of this operation is somewhat different. By design I think it opens a repository for reading. So, lets say you open a team member adapter based on JDBC, then it probably would open a connection to DB. So, opening the adapters for all the time seams to be dangerous, since it may lock some resources (eg. use all DB connection poll, lock files for writing, or whatever).

The second problems is that it activates plugins that might have been still closed. It may cause some performance impact.

I see two possible solutions for this:
1. Make a new extension point for repositories to handle events. Like OnPCOpen event for a given repository type would make some action. This probably would be the most flexible method. 2. Add new method to adapter for opening imported repository, eg. openImported().

What do you think.
Marcin
The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it.

Back to the top