| RE: [corona-dev] Exceptions in Corona. |
|
Great idea. We also need to change returns
of null values to exceptional returns. Pawel From:
corona-dev-bounces@xxxxxxxxxxx [mailto:corona-dev-bounces@xxxxxxxxxxx] On Behalf Of Jaworowski, Piotr Hi All,
I’ve got suggestions for a code clean up. 1)
I’ve noticed several methods
which throws an Exception, (not corona specific one, classes like
AbstractTopic, Topic, EventRouter etc.). What do you think of cleaning up
the code, and changing such methods to throw at least CoronaException. 2)
There is also several places where try {
… } catch (Exception
e) {
… }
blocks can
be found. Such construction is quite dangerous, because it catches all (also
Runtime) exceptions, it should be changed to catch only exceptions which are
thrown in try block.
What do you about it, should we add such task to bugzilla?
Piotr. Ps Some useful links http://www.onjava.com/pub/a/onjava/2003/11/19/exceptions.html,
http://today.java.net/pub/a/today/2006/04/06/exception-handling-antipatterns.html. The contents of this e-mail are intended for the named addressee only.
It contains information that may be confidential. Unless you are the named
addressee or an authorized designee, you may not copy or use it, or disclose it
to anyone else. If you received it in error please notify us immediately and
then destroy it. |