| [corona-dev] RE: [Bug 157990] Consolidate PCC Workbench Plugins |
|
Hi All, I’ve
made some package renaming. Please synchronize following plug-ins: ·
org.eclipse.corona.container.project.ui ·
org.eclipse.corona.tools.ui ·
org.eclipse.corona.container.project.ui ·
org.eclipse.corona.client.collaboration.ui and ·
org.eclipse.corona.tests.tools
(as small changes were done in org.eclipse.corona.tools.ui) Thanks, Piotr From: Everitt, Glenn Great news! So, I think the next
step is to rename the packages as you have them below… as you mentioned a
while ago ;-) Thanks Glenn Everitt From: Hi Glenn, It's done in the way you have written.
(See my comments below in blue). Additionally, I thought it would be better
to rename also old packages, to new names like: * org.eclipse.corona.project.container.explorer ->
org.eclipse.corona.container.project.ui.explorer * org.eclipse.corona.project.container.view ->
org.eclipse.corona.container.project.ui.view * org.eclipse.corona.client.project.builder ->
org.eclipse.corona.container.project.ui.builder * org.eclispe.corona.client.project.ui (I’ve heard from Pawel
that this plugin is deprecated, so it can be either removed or marked as
@deprecated (each class)). And this is not done. I’m not sure
if it’s a good idea to rename also package names, what do you think about
this? Cheers, Piotr -----Original Message----- I guess I'm confused I thought the packages would be moved into the new
bundle with the same package name. The old plugins that contained the
packages should have been closed. Finally, the plugins dependent on the
closed plugins should be updated to the new consolidated plugin
org.eclipse.corona.container.project.ui So, All these PACKAGES moved into org.eclipse.corona.container.project.ui * org.eclipse.corona.project.container.explorer * org.eclipse.corona.project.container.view * org.eclipse.corona.client.project.builder * org.eclispe.corona.client.project.ui All Packages you mentioned are moved into new plugin. All PLUGIN's named: * org.eclipse.corona.project.container.explorer * org.eclipse.corona.project.container.view * org.eclipse.corona.client.project.builder * org.eclispe.corona.client.project.ui are CLOSED. All mentioned plugins can be closed
after cvs synchronization. Update all MANIFEST.MF of plugins dependent on these closed plugin
projects: * org.eclipse.corona.project.container.explorer * org.eclipse.corona.project.container.view * org.eclipse.corona.client.project.builder * org.eclispe.corona.client.project.ui All plugins which
were depending on above plugins, now depends on
org.eclipse.corona.container.project.ui. to new dependency (Required Plug-ins tab) on plugin org.eclipse.corona.container.project.ui That's what I was hoping was going to happen. Glenn Everitt -----Original Message----- From: Sent: Monday, September 25, 2006 8:16 AM To: Cc: Everitt, Glenn Subject: RE: [Bug 157990] Consolidate PCC Workbench Plugins Re: package renaming.... Glenn has been leading this. I'll talk to him when he gets in
this morning. -Dennis -----Original Message----- From: Sent: Monday, September 25, 2006 4:16 AM To: Subject: RE: [Bug 157990] Consolidate PCC Workbench Plugins Hi Dennis, About > Consolidation is not complete. The
plugin still has dependencies on
org.eclipse.corona.project.container.view, both in its manifest as
well as in plugin.xml. < I didn’t done any package renaming
yet, thus org.eclipse.corona.project.container.view package still exist in the
code. All accurances of "org.eclipse.corona.project.container.view"
are either package export in manifest file, or package names (or ids) in the
plugin.xml files. I've found one dependencie to org.eclipse.corona.project.container.view
in org.eclipse.corona.client.collaboration.ui project in its manifest file. Have you found some other dependencies? Any way would you like me also to rename
the packages so that "org.eclipse.corona.project.container.view" does
not appear in the code? Piotr |