[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-dev] CDT Call Wednesday
|
Jonah Graham wrote:
> I see this commit addresses some of the other cases by using response files to handle long command lines for ar, gcc, etc.
>
> Can you add your comment to https://bugs.eclipse.org/bugs/show_bug.cgi?id=505882 and consider a patch? I think that Torbjörn's change handles the performance tradeoff better for the rm case, but your change fixes it more widely.
That patch was posted a long time ago at https://bugs.eclipse.org/bugs/show_bug.cgi?id=72965 and as far as I understand there were concerns about the response file part because not all linkers understand response files - ours do, so we didn't bother distinguishing. There is another patch there by Serge Beauchamp that apparently addresses that by letting the toolchain definition control it. Maybe they could be combined.
I do have it on my to-do list for the near future to go over our old patches and bug reports, so I’ll see what I can do.
I hadn’t seen 505882 and Torbjörn’s patch yet when I wrote my comment (I was working through emails sequentially after returning from vacation), I haven’t studied it in detail yet but I agree his approach is probably better. I’ll try to merge it into our stuff.
-Christian
