| Re: [cdt-dev] Custom language.settings.xml file is not allways applied on project open |
|
Hello Jonah, all,
Regarding this topic, Unfortunately using
+ storeInPrjArea.refreshLocal(IResource.DEPTH_ZERO, null); It seems to help , from UI seems to be ok, but in the Logs I can see following DeadLocks for about every second project that I open. The projects we create are based on existing sources that has svn. On open, SVN plugin shares them automatically and this causes following deadlock. I suppose both, cdt and svn plugins are trying to refresh/access same resources at the same time. !MESSAGE Deadlock detected. All locks owned by thread main will be suspended. java.lang.IllegalStateException at org.eclipse.core.internal.jobs.DeadlockDetector.reportDeadlock(DeadlockDetector.java:599) at org.eclipse.core.internal.jobs.DeadlockDetector.lockWaitStart(DeadlockDetector.java:403) at org.eclipse.core.internal.jobs.LockManager.addLockWaitThread(LockManager.java:154) at org.eclipse.core.internal.jobs.OrderedLock.doAcquire(OrderedLock.java:168) at org.eclipse.core.internal.jobs.OrderedLock.acquire(OrderedLock.java:106) at org.eclipse.core.internal.jobs.OrderedLock.acquire(OrderedLock.java:82) at org.eclipse.cdt.internal.core.settings.model.xml.XmlProjectDescriptionStorage.getProjectDescription(XmlProjectDescriptionStorage.java:230) at org.eclipse.cdt.internal.core.settings.model.CProjectDescriptionManager.getProjectDescriptionInternal(CProjectDescriptionManager.java:426) at org.eclipse.cdt.internal.core.settings.model.CProjectDescriptionManager.getProjectDescription(CProjectDescriptionManager.java:408) at org.eclipse.cdt.managedbuilder.core.ManagedBuildManager.findBuildInfo(ManagedBuildManager.java:2730) at org.eclipse.cdt.managedbuilder.core.ManagedBuildManager.getBuildInfo(ManagedBuildManager.java:2991) at org.eclipse.cdt.managedbuilder.core.ManagedBuildManager.getBuildInfo(ManagedBuildManager.java:2946) at org.eclipse.cdt.managedbuilder.core.ResourceChangeHandler2$Visitor.visit(ResourceChangeHandler2.java:123) at org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:64) at org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:75) at org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:48) at org.eclipse.cdt.managedbuilder.core.ResourceChangeHandler2.resourceChanged(ResourceChangeHandler2.java:180) at org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:299) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:289) at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:152) at org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:374) at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1469) at org.eclipse.core.internal.resources.Project.touch(Project.java:1326) at org.eclipse.team.core.RepositoryProvider.map(RepositoryProvider.java:132) at org.tigris.subversion.subclipse.core.resources.SVNWorkspaceRoot.setSharing(SVNWorkspaceRoot.java:229) at org.tigris.subversion.subclipse.core.SVNTeamProviderType$AutoShareJob.autoconnectSVNProject(SVNTeamProviderType.java:136) at org.tigris.subversion.subclipse.core.SVNTeamProviderType$AutoShareJob.run(SVNTeamProviderType.java:98) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56) !SUBENTRY 1 org.eclipse.core.jobs 4 2 2019-12-12 16:37:41.647 !MESSAGE Thread Worker-3 has locks: F/DemoProject/.settings, R/, OrderedLock (7), OrderedLock (0) and is waiting for lock OrderedLock (11) !SUBENTRY 1 org.eclipse.core.jobs 4 2 2019-12-12 16:37:41.647 !MESSAGE Thread main has locks: OrderedLock (11) and is waiting for lock F/DemoProject/.settings Not sure if I can ignore such errors. I also found that, at some point the language settings that I want to apply is removed, when it goes wrong. And if I comment following line in yellow, it seems to solve my problem. Even if in the beginning
isStoreInProjectAreaExist = false,but if the language settings file is not removed, at some point it is successfully applied.
What side effect it could cause if I comment this line ? Or maybe you have other ideas? How could I postpone this workflow ? that checks and
loadLanguageSettings() In org.eclipse.cdt.internal.core.language.settings.providers.LanguageSettingsProvidersSerializer.serializeLanguageSettings(ICProjectDescription prjDescription) … try { serializingLock.acquire(); if (!isEqualToDefaultProviders(prjDescription)) { serializeLanguageSettingsInternal(projectElementStorePrj, projectElementStoreWsp, prjDescription); } // Absent store means default providers as specified in the toolchain IFile fileStorePrj = getStoreInProjectArea(project); boolean isProjectStoreEmpty = projectElementStorePrj.getChildNodes().getLength() == 0; if (isProjectStoreEmpty) { if (fileStorePrj.exists()) { // fileStorePrj.delete(true, null); } } else { … Thank you in advance Kind Regards Lidia From: Popescu, Lidia
Thanks
Jonah, Your snipped seems to help, same as mine where I just added Thread.sleep() for 5 seconds and re-tried to get the file and boolean value. But I still have to see if it fixes the problem on someone’s else side, who happens to have it more often. I will let you know then how it goes. Kind Regards Lidia From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Jonah Graham Hello Lidia, Unfortunately there are indeed some race conditions in the code - It looks like you have discovered one of them. If it is a refresh problem, I wonder if doing the below would help. Can you try it? public static void loadLanguageSettings(ICProjectDescription prjDescription) { Perhaps that will make sure the state of the file is up to date. I am not sure what (negative) side effects there are with doing that here - as a first step it would be good to know if that resolves the issue. Jonah On Tue, 10 Dec 2019 at 14:37, Popescu, Lidia <lidia.popescu@xxxxxxxxxxxxx> wrote:
|
