Re: [cdt-dev] CDT 9.3.3

[Doug Schaefer <dschaefer@xxxxxxxxxxxxxx>]

> -----Original Message-----
> From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Jonah Graham
> Sent: Sunday, October 8, 2017 2:53 PM
> To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
> Subject: Re: [cdt-dev] CDT 9.3.3
> 
> (BTW the below feels like spending too much time on this issue...)

Not really. We need to come to an understanding or we'll keep reverting each other's commits 😊

> 
> It broke the ability to update the plug-in and features using the one line mvn
> command:
> mvn org.eclipse.tycho:tycho-versions-plugin:set-version -P build-standalone-
> debugger-rcp -DnewVersion=${NEW_VERSION}-SNAPSHOT
> With that command setting the feature versions to the right thing is trivial. I
> suspect other automatic editing command for Maven will be affected too, but I
> haven't tried them.

I'm curious to why that would be broken. What assumptions is that Mojo making?

> As for feature groupids inheriting, we could look at that.  I think our root
> problem is that CDT existed before Tycho and tycho's normal way of operating
> (AFAICT) is to have the feature have a different name than any plug-in. This
> makes sense with the namespace constraints of an Eclipse workspace too. This
> being another place that CDT is unusual in that the feature projects name's don't
> match the CDT feature IDs.
> That said, JDT does the same as CDT, but JDT's features have pom files. Most
> other (younger) projects that I have seen just tag on .feature to the ID of their
> features.

Tycho/Maven don't really care what the layout is in general. Pomless builds do require the parent directory of the project have a pom file. And maybe that works best when all features are in a features folder and all bundles are in a bundles folder as seems to be the most common style.

BTW, as one who types in IU ids often, having something that's org.blah.feature.feature.group looks silly. There are other ways.

> It sounds like a Tycho bug (wrong reactor order) if there is a dep from UI test to
> CDT feature and the CDT feature is not built first.
> Good to know that is the reason for the workaround.

Plug-ins can't depend on features. This comes from the extraRequirements clause in the cmake.ui.tests plug-in. It doesn't seem to impact the reactor order. Without it, I didn't get the C++ Perspective and the CMake project templates and the test failed.

I'll take a deeper look at set-versions and see what it's expecting.

> Jonah
> 
> ~~~
> Jonah Graham
> Kichwa Coders Ltd.
> www.kichwacoders.com
> 
> On 8 October 2017 at 19:15, Doug Schaefer <dschaefer@xxxxxxxxxxxxxx>
> wrote:
> >
> > BTW, Jonah, when you say the change broke tycho/maven, what exactly
> broke? The builds seem fine.
> >
> >
> >
> > From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> > On Behalf Of Doug Schaefer
> > Sent: Sunday, October 8, 2017 2:00 PM
> >
> >
> > To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
> > Subject: Re: [cdt-dev] CDT 9.3.3
> >
> >
> >
> > To allow for UI tests to include CDT features, we have found that the test
> plug-ins need to be last in the build. Flattening should work. Where the modules
> are listed shouldn’t matter.
> >
> >
> >
> > I also wonder if our root problem is that the features need to be in a features
> directory that has a pom file with the features groupId on it. I believe the pom-
> less projects inherit the groupId from the pom file in the immediate parent
> directory. Be worth a try. Our goal should be to have pom-less projects
> wherever possible.
> >
> >
> >
> > From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> > On Behalf Of Jonah Graham
> > Sent: Saturday, October 7, 2017 6:16 PM
> > To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
> > Subject: Re: [cdt-dev] CDT 9.3.3
> >
> >
> >
> > CDT 9.3.3:
> >
> > I have fixed the version numbers in the features[1]. I also fixed the pom's so
> that the (nearly) single-line command works properly to update the versions[2].
> In addition I documented the command on the releng page[3].
> >
> >
> >
> > Master branch:
> >
> > That said, the master branch has had some re-jigging done to the pom.xmls
> which broke tycho/maven[4]. This is because this change has the root refer to
> modules two levels deeper, but those module's refer to their immediate parent
> directory implicitly because of pomless builds. I'll try and fix this, but can you
> confirm the (secondary - pom.xml changes) purpose of [4] was that build would
> run before test? If so, can you do "mvn package && mvn verify" instead of
> flattening everything into root pom? If that works, I would like to revert the
> secondary - pom.xml changes.
> >
> >
> >
> > [1] https://git.eclipse.org/r/#/c/106405
> >
> > [2] https://git.eclipse.org/r/#/c/106406
> >
> > [3]
> > https://wiki.eclipse.org/CDT/release_engineering#Miscellaneous_release
> > _checklist
> >
> > [4] https://git.eclipse.org/r/#/c/106254
> >
> >
> >
> > Thanks,
> >
> > Jonah
> >
> >
> >
> >
> > ~~~
> > Jonah Graham
> > Kichwa Coders Ltd.
> > www.kichwacoders.com
> >
> >
> >
> > On 7 October 2017 at 11:26, Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
> wrote:
> >
> > OK, I am updating the feature versions now.
> >
> >
> > ~~~
> > Jonah Graham
> > Kichwa Coders Ltd.
> > www.kichwacoders.com
> >
> >
> >
> > On 6 October 2017 at 18:26, Doug Schaefer <dschaefer@xxxxxxxxxxxxxx>
> wrote:
> >
> > Cool. Sounds good.
> >
> >
> >
> > One of the unfortunately things we’ll need is to update the features to version
> 9.3.3. There’s almost 20 of them so it’s a bit painful. Jonah, could you check into
> that.
> >
> >
> >
> > Thanks!
> >
> > Doug.
> >
> >
> >
> > From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> > On Behalf Of Corbat Thomas
> > Sent: Friday, October 6, 2017 1:12 PM
> >
> >
> > To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
> > Subject: Re: [cdt-dev] CDT 9.3.3
> >
> >
> >
> > I’ve just cherry-picked the fix for Bug 525645 to the CDT 9.3 branch (not in
> Gerrit as I had a merge-conflict) and set the milestone to 9.3.3.
> >
> > When Jenkins is happy with it, I’ll submit it.
> > https://git.eclipse.org/r/#/c/106354/
> >
> > Then I’m good to go for 9.3.3
> >
> >
> >
> > BR
> >
> > Thomas
> >
> >
> >
> > From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
> > On Behalf Of Jonah Graham
> > Sent: Freitag, 6. Oktober 2017 14:20
> > To: CDT General developers list. <cdt-dev@xxxxxxxxxxx>
> > Subject: Re: [cdt-dev] CDT 9.3.3
> >
> >
> >
> > I have now created the bugs that I intend to fix for 9.3.3:
> >
> >
> >
> > https://bugs.eclipse.org/bugs/buglist.cgi?product=CDT&target_milestone
> > =9.3.3
> >
> >
> >
> > They are all fairly small changes (but with big user impact) to fix NPEs and
> similar type problems.
> >
> >
> > ~~~
> > Jonah Graham
> > Kichwa Coders Ltd.
> > www.kichwacoders.com
> >
> >
> >
> > On 5 October 2017 at 11:08, Jonah Graham <jonah@xxxxxxxxxxxxxxxx>
> wrote:
> >
> > Hi folks,
> >
> >
> >
> > As discussed at the CDT monthly I would like to have a bug fix release (CDT
> 9.3.3) soon. I believe I will be ready by Tuesday for this.
> >
> >
> >
> > The improvements are some debug bug fixes. I will create the target milestone
> and assign bugs to them later today/tomorrow.
> >
> >
> >
> > Thanks
> >
> > Jonah
> >
> >
> > ~~~
> > Jonah Graham
> > Kichwa Coders Ltd.
> > www.kichwacoders.com
> >
> >
> >
> >
> >
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or
> > unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> >
> >
> >
> >
> >
> >
> > _______________________________________________
> > cdt-dev mailing list
> > cdt-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or
> > unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/cdt-dev
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit https://dev.eclipse.org/mailman/listinfo/cdt-dev