Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] IIndex.getFilesWithUnresolvedIncludes() returns excluded files 
All

I did some more investigation in this issue and found the following:
In both cases (excluding and removing the exclude) the debugger passes at line 822 in PDomManager 

            updateProject(project, added, changed, removed);
and the parameters added, changed and removed are the same (containing all files in the project!!!)
So it looks like DeltaAnalyzer does not create a correct delta. Looking closer at DeltaAnalyzer it looks ok; but it also doesn't take into account excluded resources. Having no clue what is going on here, and no clue what is supposed to go on, I feel as if the code behind the exclude "invalidates the whole project" which makes the change to contain the whole project content -whatever that may mean-. 

But I'm seriously out of my depth here so don't take this seriously

Best regards

Jantje



Op 5/06/2017 om 14:46 schreef Jonah Graham:

Hi Jantje,

It sounds like you have found a legitimate bug. Can you see how to fix
it? Obviously the index update is being triggered properly when
exclude is removed.

These are the questions I would aim to answer (in order):
Is the index update process being run when a folder is excluded?
Is the index failing to see the change?
Is the index seeing the change, but failing to remove a file that is
now excluded?

I am not sure how to fix this, hopefully someone else on the list has
a better idea.

Jonah


~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 4 June 2017 at 17:45, Jan Baeyens <jan@xxxxxxxxxx> wrote:

Jonah

Thanks for the answer.

I investigated this more in detail and I can reproduce the issue as follows.
Create a CDT project with following files
main.cpp
hide/hide.h
hide/hide.cpp

hide.h contains
extern int doYouSeeMe;

hide.cpp contains
  int doYouSeeMe=8;

main.cpp contains
void haha(){
     int t;
     t=doYouSeeMe;
}

ctrl left click on doYouSeeMe in main.cpp and you go to hide.cpp
add the hide folder to the excluded resources
ctrl left click still sends you to hide.cpp
rebuild the index
ctrl left click no longer works (as should be)

undo the exclude and all works again
Exclude hide.cpp and doYouSeeMe is still found in hide.cpp
Rebuild the index and crtl left click leads to hide.h

It looks as if excluding files does not properly adjusts the index.

Best regards
Jantje




Op 31/05/2017 om 16:53 schreef Jonah Graham:

Sorry I don't have a proper answer for you on your questions. Perhaps

my incomplete answers will stimulate some conversation.

On 29 May 2017 at 01:18, Jan Baeyens <jan@xxxxxxxxxx> wrote:

Is this by design or is this a bug?

I don't know. Could easily be by design as the indexer tries to index
everything.


In both cases what is the best way to check whether the file is a
excluded
file?

Are you referring to the build settings? My guess is you need to look
in the project description code rather than the indexer code to figure
that out.
_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from
this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev

Back to the top