Re: [cdt-dev] performApply does not save at BinaryParsTab class

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

I am not 100% sure what the comment refers to. My *guess* is that it is referring to the UI that existed before the "newui". If so that comment means: Settings from binary parser pages are not saved in CDT versions before CDT 4.0, so parsers settings saved in CDT versions <= 4.0 always use default values... Note the pre CDT 4.0 version of the page is org.eclipse.cdt.ui.dialogs.BinaryParserBlock, the "newui" is the one you reference, note the newui in the package name: org.eclipse.cdt.ui.newui.BinaryParsTab

Therefore, if you could explain what specifically is failing, and if you have a reproducible test case put it in a bug report https://bugs.eclipse.org/bugs/enter_bug.cgi?product=CDT. If you also provide a fix I would be happy to review it.

Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On 26 April 2017 at 13:12, ilke Muhtaroglu <ilke.muhtaroglu@xxxxxxxxx> wrote:

I browse and select new values at C build -  Settings -  Binary Parsers via Binary Parser Options as a command.

But these selected values are can not be saved. 

At the BinaryParsTab there is a comment. So these BinaryParserPages are can not be saved at the moment as well ...

/**
	* @noextend This class is not intended to be subclassed by clients.
	*/
	public class BinaryParsTab extends AbstractCPropertyTab {
	/* Settings from binary parser pages are NOT saved by prior CDT version.
	* So existing binary parsers _always_ use default values.
	* Moreover, obsolete interface is used while attempting to save.
	*
	* We have to affect both parsers and pages
	* to teach them to save data really.
	*
	* It will be done in next versions. Currently pages are disabled.
	*/

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev