Re: [cdt-dev] Cleanup of imports

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Hi Marco,

I would be happy to review and apply such a gerrit change.

To answer your questions. CDT devs haven't purposefully ignored that
recommendation, but that recommendation is a per-project settings
recommendation, not a workspace recommendation. Some projects are set
up correctly[1]. There are likely projects that don't have that
setting, as it is also likely that some projects were created before
that recommendation came into force.

Therefore, if you have your workspace set to errors for this setting,
you will see errors that cdt-devs don't see.

Jonah

[1] for example org.eclipse.cdt.dsf.gdb, see Line 60 of
https://git.eclipse.org/c/cdt/org.eclipse.cdt.git/tree/dsf-gdb/org.eclipse.cdt.dsf.gdb/.settings/org.eclipse.jdt.core.prefs#n60
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 18 October 2016 at 07:51, Marco Syfrig <marco.syfrig@xxxxxxxxx> wrote:
> https://wiki.eclipse.org/CDT/policy#Eclipse_Java_Errors.2FWarnings says that
> unused imports should generate an error. And there are some projects that
> have unused imports, most of my errors are from unused imports and I don’t
> like having errors in my workspace and every time I run the CDT to get a
> notification about errors in my projects I try to run (I know I can suppress
> that but I would want to know if I really have an error).
>
> So, could someone with contributor rights just do a quick cleanup of the
> imports and commit it? I don’t have commited anything yet to CDT so I have
> not set up gerrit but could do that if you prefer.
>
> However, it makes me wonder if all other CDT devs just ignore the
> recommended error/warning settings or just don’t care that there are errors.
>
> _______________________________________________
> cdt-dev mailing list
> cdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/cdt-dev