Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] master API breakage

Now that I have the .api_filters file in my workspace, I wait until I have some time to push it in. I might do it direct since our verify job takes so long to run and doesn’t actually test this.

From: <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Marc Khouzam <marc.khouzam@xxxxxxxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Monday, June 13, 2016 at 2:18 PM
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] master API breakage

Could we have that change in its own commit?
You can just make the change on top of your commit and when
you push to Gerrit, it will create two reviews automatically.


From: cdt-dev-bounces@xxxxxxxxxxx [cdt-dev-bounces@xxxxxxxxxxx] on behalf of Doug Schaefer [dschaefer@xxxxxxxxxxxxxx]
Sent: June 13, 2016 2:14 PM
To: CDT General developers list.
Subject: Re: [cdt-dev] master API breakage

OK, I’m working on a change request and will add in the filter there.

From: <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Monday, June 13, 2016 at 2:13 PM
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] master API breakage

I was improving performance of HasTable and did some code cleanup to make it slightly less error prone. Agree with the API filter point. Unfortunately, I don't get the error that would allow me to create a filer easily. Do you mind creating the API filer on my behalf while I'm sorting out problems with the baseline?

-sergey

On Mon, Jun 13, 2016 at 11:03 AM, Doug Schaefer <dschaefer@xxxxxxxxxxxxxx> wrote:
Actually, this is the only breakage I see since moving to the latest cdi-baseline.target for my baseline.

I guess, it begs the question, why did you make the change to HashTable? I assume you had a good reason and we should create an api filter for it instead, I guess.

D

From: <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>
Reply-To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date: Monday, June 13, 2016 at 1:38 PM
To: "CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Subject: Re: [cdt-dev] master API breakage

Formally this is a breaking API change, but HashTable and its subclasses have never been intended for subclassing by the client code. What is surprising is that I don't see this error even after a clean rebuild.

-sergey

On Mon, Jun 13, 2016 at 8:22 AM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
Hey gang,

Sergey made one of the methods in HashTable final. The API tools are telling me that this is an API change, which I guess it is if someone has overriden the method and expects it to get called.

Did anyone else see that? Or do I have something misconfigured?

Thanks,
Doug

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


Back to the top