[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [cdt-dev] Parameter Guessing
|
Hi Nathan,
Thanks for taking a look at this.
I was able to do a quick debugging today, and it seems that the reason we don't get a list of proposals is what you fixed in this patch: https://git.eclipse.org/r/#/c/74172/1/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/DOMCompletionProposalComputer.java
I am not sure why, but it seems that this getparent() makes binding resolution not able to figure out the declared variables.
Maybe Sergey can verify if this ever worked before or is it a regression on this API, as he did this last refactoring?
I didn't take a look at the rest of the patches, but if this mentioned changes alone solves the problem, what does the other patches do?
cc'ing Sergey.
Thanks and Best Regards,
Mohamed Azab
> -----Original Message-----
> From: Nathan Ridge [mailto:zeratul976@xxxxxxxxxxx]
> Sent: Wednesday, June 01, 2016 5:49 PM
> To: CDT Mailing List; Azab, Mohamed
> Subject: RE: [cdt-dev] Parameter Guessing
>
> > Considering the amount of patches you needed to post, the fact we don't
> have a good handle on this feature, and that the tests weren't actually giving us
> proper feedback, we should give up on this for 9.0 at this very late stage.
>
> Note that the number of patches isn't an indication of complexity, I just split
> the change up into granular commits.
>
> That said, I tend to agree that given the lack of testing, it's a risky change to put
> into RC4.
>
> > Are we currently dealing with a half working situation? We need to turn it off
> in a consistent manner so it can be brought in for 9.1. Are any changes needed
> for that? Could they cause more damage than good?
>
> I think it might work in some cases, but, worryingly, it can access the index
> without acquiring the index read lock.
>
> It should be safe to disable it the way Sergey disabled it before while
> investigating a performance regression [1]. I can put together a patch tonight
> after I get home from my day job.
>
> Regards,
> Nate
>
> [1]
> http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=4ac6657792353e6fd
> 473e2f6c34baaf0538d1261
>
